18315 - [perf] cache "miss" of overlays.rdf & chrome.rdf

Status: RESOLVED FIXED

(Core :: XUL, defect, P2)

Description

[Chris Waterson]

overlays.rdf and chrome.rdf are read a zillion times on startup. The versions in
the "global" directory are read multiple (e.g., 21) times, even though the file
doesn't exist.

Cache the "miss" of these files so that we don't waste I/O trying to find them
over and over.

On Mac startup, this accounts for at least 0.5s.

Comment 1

[Stuart Parmenter]

i know how to fix this and will attach a patch in a few

Comment 2

[Stuart Parmenter]

Attachment: patch to fix the problem

Comment 3

[Chris Waterson]

fix looks good to me pav. check it in when M12 opens.

Comment 4

[Simon Fraser [no longer active]]

This patch is bollocks. You can't put nsnull into an nsSupportsHashTable, because
the hash table calls NS_ADDREF on it. It crashes on my machine.

Comment 5

[Chris Waterson]

pav: use something besides an nsSupportsHashTable, and just put a "1" in there.

Comment 6

[Simon Fraser [no longer active]]

Alternatively, change nsSupportsHashTable to allow null entries (change a bunch
of NS_ADDREF to NS_IF_ADDREF, and NS_IF_RELEASE).

Comment 7

[Simon Fraser [no longer active]]

Checked in a fix -- make nsSupportsHashTable capable of having null entries, and
checked in the rdf part of pav's patch.

Comment 8

[Chris Waterson]

i'll verify this one...

Comment 9

[leger]

BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.