1831648 - Mozbuild requires packaging module but is not listed as dependency

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect, P3)

Description

[Heitor Neiva [:hneiva]]

Mozbuild started using "packaging" module [1]
But the dependency was not listed in setup.cfg [2]

[1] https://phabricator.services.mozilla.com/D161756
[2] https://searchfox.org/mozilla-central/source/python/mozbuild/setup.py#17

While not a problem in gecko, as it installs the module from other dependencies, it's a problem for other repos (ie scriptworker-scripts) when we vendor it.

Comment 1

[BugBot [:suhaib / :marco]]

:ahochheiden, since you are the author of the regressor, bug 1798827, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1831648 - Add missing dependencies to `setup.py` for `mozbuild` r?#build

Comment 3

[[:sergesanspaille]]

Looks like https://github.com/r1chardj0n3s/pip-check-reqs could be used to avoid such regression in the future.

Comment 4

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1798827

Comment 5

[Alex Hochheiden [:ahochheiden] [he/him]]

After speaking with :glandium, we decided to go in a different direction on this, and remove the setup.py altogether for all of mach, mozbuild, and mozboot directories. It may have made sense at some point to allow them to be standalone packages, but we feel that is no longer the case. Updating them would signal we still care about supporting that, so we'll do the opposite and remove them to indicate we no longer feel they should be depended on in this way.

Comment 6

[Heitor Neiva [:hneiva]]

Hey Alex, can this be resolved?

Comment 7

[Alex Hochheiden [:ahochheiden] [he/him]]

This still needs to be done. I'll get around to it eventually.

Comment 8

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1831648 - Remove `setup.{py,cfg} ` files from `mach`, `mozbuild`, and `mozboot` r?#build

These may have made sense as standalone packages, but that's no longer the case.

Dependencies are specified via the various python/sites/* files and site used
depends on which command is being run.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/87ef2ec70bc3
https://hg.mozilla.org/integration/autoland/rev/21ee28c26244
Remove `setup.{py,cfg} ` files from `mach`, `mozbuild`, and `mozboot` r=firefox-build-system-reviewers,nalexander

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/21ee28c26244