Closed Bug 1831817 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 39884 - [css-flex] Fix broken spine

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
115 Branch
Tracking Flags:
Tracking Status
firefox115 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39884 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39884
Details from upstream follow.

David Grogan <dgrogan@chromium.org> wrote:

[css-flex] Fix broken spine

Flex was laying out a node in a MinMaxSizes pass after a layout had
already been done. This requires a NGDisableSideEffectsScope to prevent
LayoutObjects and fragments from getting out of sync.

This patch adds the NGDisableSideEffectsScope.

Fixed: 1440908
Change-Id: I34dfcc93f99d100c3bec5d03c2b90944ea37a8f8
Reviewed-on: https://chromium-review.googlesource.com/4510548
WPT-Export-Revision: 9d14f7f3b17ffd3391a12c0ea747ba8866552039

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core
Try push failed: decision task XePmkq5fRr67OrBiME2uLg returned error
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Try push failed: decision task SiT1-Md0ST-KkgMFAd59Yg returned error
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a394cd2d913 [wpt PR 39884] - [css-flex] Fix broken spine, a=testonly https://hg.mozilla.org/integration/autoland/rev/4e1268af2d19 [wpt PR 39884] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8a394cd2d913
https://hg.mozilla.org/mozilla-central/rev/4e1268af2d19

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox115: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.