1832028 - "input.#getElementFromElementOrigin()" has to raise "no such element" error for non Elements as element origin.

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

With the handling of Element Origin via bug 1806788 the newly added method input.#getElementFromElementOrigin() which is part of the windowglobal input module currently retrieves any kind of node and returns it without checking if it is an Element as the BiDi spec describes:

https://w3c.github.io/webdriver-bidi/#get-element-from-inputelementorigin-steps

Let element be the result of trying to deserialize remote reference with reference, realm, and session.

If element doesn’t implement Element return error with error code no such element.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1832028 - [bidi] Throw NoSuchElement if ElementOrigin's node is not an element

At the moment the actions module would already throw an InvalidArgument error, but for BiDi we want explicitly to throw NoSuchElement in this case.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1832028 - [wdspec] Add test for NoSuchElement error with input.ElementOrigin

Depends on D178185

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f71f2bcd92f
[bidi] Throw NoSuchElement if ElementOrigin's node is not an element r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/b0a6c81cf587
[wdspec] Add test for NoSuchElement error with input.ElementOrigin r=webdriver-reviewers,jgraham

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40127 for changes under testing/web-platform/tests

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6f71f2bcd92f
https://hg.mozilla.org/mozilla-central/rev/b0a6c81cf587

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot