Closed Bug 1832028 Opened 5 months ago Closed 4 months ago

"input.#getElementFromElementOrigin()" has to raise "no such element" error for non Elements as element origin.

Categories

(Remote Protocol :: WebDriver BiDi, defect, P1)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
defect
Points:
1

Tracking

(firefox115 fixed)

Status:
RESOLVED FIXED
Milestone:
115 Branch
Tracking Flags:
Tracking Status
firefox115 --- fixed

People

(Reporter: whimboo, Assigned: jdescottes)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [webdriver:m7][wptsync upstream][webdriver:relnote])

Attachments

(2 files)

Bug 1832028 - [bidi] Throw NoSuchElement if ElementOrigin's node is not an element
48 bytes, text/x-phabricator-request
Details | Review
Bug 1832028 - [wdspec] Add test for NoSuchElement error with input.ElementOrigin
48 bytes, text/x-phabricator-request
Details | Review

With the handling of Element Origin via bug 1806788 the newly added method input.#getElementFromElementOrigin() which is part of the windowglobal input module currently retrieves any kind of node and returns it without checking if it is an Element as the BiDi spec describes:

https://w3c.github.io/webdriver-bidi/#get-element-from-inputelementorigin-steps

Let element be the result of trying to deserialize remote reference with reference, realm, and session.

If element doesn’t implement Element return error with error code no such element.

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED

At the moment the actions module would already throw an InvalidArgument error, but for BiDi we want explicitly to throw NoSuchElement in this case.

Attachment #9334135 - Attachment description: Bug 1832028 - [bidi] Throw NoSuchElement when passing Document/DocumentFragment as ElementOrigin → Bug 1832028 - [bidi] Throw NoSuchElement if ElementOrigin's node is not an element
Severity: -- → S3
Points: --- → 1
Priority: -- → P1
Whiteboard: [webdriver:m7]
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f71f2bcd92f
[bidi] Throw NoSuchElement if ElementOrigin's node is not an element r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/b0a6c81cf587
[wdspec] Add test for NoSuchElement error with input.ElementOrigin r=webdriver-reviewers,jgraham
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40127 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m7] → [webdriver:m7], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/6f71f2bcd92f
https://hg.mozilla.org/mozilla-central/rev/b0a6c81cf587

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox115: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
Upstream PR merged by moz-wptsync-bot
Whiteboard: [webdriver:m7], [wptsync upstream] → [webdriver:m7][wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.