1832132 - `BROWSER_SET_DEFAULT_USER_CHOICE_RESULT` telemetry broken after Bug 1805509

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect)

Description

[Nick Alexander :nalexander [he/him]]

There's a clear change from Success to ErrOther between Firefox 111 and Firefox 112 that I attribute, without being 100% certain, to Bug 1805509.

See https://glam.telemetry.mozilla.org/firefox/probe/browser_set_default_user_choice_result/explore?activeBuckets=%5B%22ErrOther%22%2C%22ErrProgID%22%2C%22ErrHash%22%2C%22ErrLaunchExe%22%2C%22Success%22%2C%22ErrExeTimeout%22%2C%22ErrExeProgID%22%2C%22ErrExeHash%22%2C%22ErrExeRejected%22%2C%22ErrExeOther%22%5D&channel=release&currentPage=1&os=Windows&process=parent&timeHorizon=QUARTER.

I think the issue is that the new _handleWDBAResult call isn't necessarily updating this.telemetryResult, but I've not dug into this.

Comment 1

[Nick Alexander :nalexander [he/him]]

brennie: do you have bandwidth to address this?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1805509

Comment 3

[Beth Rennie [:beth] (she/her)]

The old code would set telemetryResult = Success after a successful operation, but that line got dropped in the refactor. Should be an easy fix.

Comment 4

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1832132 - Correctly report success in BROWSER_SET_DEFAULT_USER_CHOICE_RESULT r?nalexander

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16db2816a62a
Correctly report success in BROWSER_SET_DEFAULT_USER_CHOICE_RESULT r=nalexander

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/16db2816a62a

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:barret, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Beth Rennie [:beth] (she/her)]

Comment on attachment 9332457 [details]
Bug 1832132 - Correctly report success in BROWSER_SET_DEFAULT_USER_CHOICE_RESULT r?nalexander

Beta/Release Uplift Approval Request

• User impact if declined: None. This only affects telemetry.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch only affects the string returned in the success case for BROWSER_SET_DEFAULT_USER_CHOICE_RESULT telemetry.
• String changes made/needed:
• Is Android affected?: No

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9332457 [details]
Bug 1832132 - Correctly report success in BROWSER_SET_DEFAULT_USER_CHOICE_RESULT r?nalexander

Approved for 114.0b3 and 113.0.1.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/18df86bdf2bd

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/9c7fab47c41a

Comment 12

[Nick Alexander :nalexander [he/him]]

Returning to this: in https://glam.telemetry.mozilla.org/firefox/probe/browser_set_default_user_choice_result/explore?activeBuckets=%5B%22Success%22%2C%22ErrProgID%22%2C%22ErrHash%22%2C%22ErrLaunchExe%22%2C%22ErrExeTimeout%22%2C%22ErrExeProgID%22%2C%22ErrExeHash%22%2C%22ErrExeRejected%22%2C%22ErrExeOther%22%2C%22ErrOther%22%5D&aggregationLevel=version&channel=release&currentPage=1&os=Windows&process=parent, I see a clear return to the expected success rate. See attached screen shot.

Comment 13

[Nick Alexander :nalexander [he/him]]

Attachment: Graph showing reversion to expected success rate

Comment 14

[Alice Varro [avarro], Ecosystem QA]

Considering the fact that the success rate is visible, I'm closing this bug as verified. Thanks!

Comment 15

[Shane Hughes [:aminomancer]]

We have this bug suggesting the issue may not be fixed. Would it be possible to re-verify this on the latest releases?

Comment 16

[Alice Varro [avarro], Ecosystem QA]

Hi Shane! I'll take a look today and I'll leave a comment with the outcome.
Thanks!

Comment 17

[Valentin Bandac [:vbandac], Ecosystem QA]

Hi Shane! We have left a comment on the mentioned issue.
Thank you!