`EventDispatcher::Dispatch` should stop creating `kungFuDeathGrip` for `nsPresContext` param
Categories
(Core :: DOM: Events, defect)
Tracking
()
People
(Reporter: masayuki, Unassigned)
References
Details
It's already been marked as MOZ_CAN_RUN_SCRIPT (bug 1539884). Therefore, all params' lifetime should be guaranteed by the callers. It should stop creating kungFuDeathGrip with checking whether all callers are now safe.
|
Reporter | |
Comment 1•1 year ago
|
||
And I wonder, why it takes aTarget as nsISupports* instead of dom::EventTarget*? If it can be changed, we can save the QI cost and extra add/release refcount.
|
||
Comment 2•8 months ago
|
||
(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #1)
And I wonder, why it takes
aTargetasnsISupports*instead ofdom::EventTarget*? If it can be changed, we can save the QI cost and extra add/release refcount.
I'm fixing this in bug 1843484.
|
|
Reporter | |
Comment 3•8 months ago
|
||
(In reply to Markus Stange [:mstange] from comment #2)
(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #1)
And I wonder, why it takes
aTargetasnsISupports*instead ofdom::EventTarget*? If it can be changed, we can save the QI cost and extra add/release refcount.I'm fixing this in bug 1843484.
Thank you very much!
Description
•