1832227 - [macOS] Import Browser data window is misleading asking the user to select the `Continue` button where there is only a `Select File` button

Status: VERIFIED FIXED

(Firefox :: Migration, defect, P2)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: image.png

Found in

• 115.0a1 (2023-05-09)

Affected versions

• 115.0a1 (2023-05-09)

Tested platforms

• Affected platforms: macOS 12,
• Unaffected platforms: Windows10x64, Ubuntu 20.04

Preconditions

• new macOS profile
• have some bookmarks saved in Safari
• browser.migrate.content-modal.enabled:true

Steps to reproduce

1. Open Firefox and import data from Safari.
2. Select Safari and click Import.
3. Observe the Import Browser data window step 1 and the Select File button.

Expected result

• Continue button is displayed instead of the Select File button.

Actual result

• Step 1 asks to select the Continue button but there is only a Cancel and Select File button.

Regression range

• Most likely this started with the new implementation of the New import wizard to bug 1803445.

Additional notes

• Attached a screenshot.
• Happens with both variant 1 and variant 2.
• On the old modal the Continue button is displayed.
• Also Select File refers to a file and not a folder.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:atrif, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Argh, I don't know how we missed this. Thanks for catching it!

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1832227 - Use a button label that matches the instructions for migrating from Safari. r?kpatenio!

Comment 4

[:Gijs (he/him)]

This has 114/113 marked as unaffected, but the strings are from 113 - are the version statuses here accurate?

Comment 5

[Alexandru Trif, Desktop QA [:atrif]]

(In reply to :Gijs (he/him) from comment #4)

This has 114/113 marked as unaffected, but the strings are from 113 - are the version statuses here accurate?

Hello! 113 and 114 are affected by this as well but only if browser.migrate.content-modal.enabled:true which is currently set to false on 114 and 113. But there is an experiment running on 113 that will flip the pref to true, and later after the experiment results from 113 the feature will be turned on 114 as well. I'm not sure if I should set the flags to affected or disabled given these circumstances.

Comment 6

[:Gijs (he/him)]

(In reply to Alexandru Trif, Desktop QA [:atrif] from comment #5)

(In reply to :Gijs (he/him) from comment #4)

This has 114/113 marked as unaffected, but the strings are from 113 - are the version statuses here accurate?

Hello! 113 and 114 are affected by this as well but only if browser.migrate.content-modal.enabled:true which is currently set to false on 114 and 113. But there is an experiment running on 113 that will flip the pref to true, and later after the experiment results from 113 the feature will be turned on 114 as well. I'm not sure if I should set the flags to affected or disabled given these circumstances.

Let's just mark both affected so we can consider uplifting the patch here.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f42531d1c13
Use a button label that matches the instructions for migrating from Safari. r=flod,niklas

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6f42531d1c13

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9333165 [details]
Bug 1832227 - Use a button label that matches the instructions for migrating from Safari. r?kpatenio!

Beta/Release Uplift Approval Request

• User impact if declined: Users on macOS that try to import browsing data from Safari will get slightly unclear instructions when going through the steps to gain permission from macOS to read from the Safari profile.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed: Partially - this changes a string reference, but doesn't add any new strings. flod and I discussed this separately in Phabricator.
• Is Android affected?: No

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for Release approval ahead of next week's planned dot release as well?

Comment 11

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: Screenshot 2023-05-17 at 11.44.32.png

Verified fixed on macOS 12 with Firefox 115.0a1 (2023-05-16). The Continue button is now displayed instead of the Select File button as stated in step 1 of the Import Browser Data window.

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9333165 [details]
Bug 1832227 - Use a button label that matches the instructions for migrating from Safari. r?kpatenio!

Approved for 114.0b6.

Comment 13

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/318578d397da

Comment 14

[Mike Conley (:mconley) (:⚙️)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #10)

Did you want to nominate this for Release approval ahead of next week's planned dot release as well?

Since we're not enabling the wizard in 113 (except for small testing populations, most of whom are not on macOS), I think we can safely skip it.

Comment 15

[Alexandru Trif, Desktop QA [:atrif]]

Verified fixed with Firefox 114.0b6 on macOS 12. The Continue button is displayed as shown in step 1 of the Import Browser Data window.