Closed
Bug 1832264
Opened 3 years ago
Closed 3 years ago
Try to simplify RegExpExec handling of CCWs
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
115 Branch
| Tracking | Status | |
|---|---|---|
| firefox115 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
After the changes in bug 1831314, we still call into self-hosted code in RegExpExec to unwrap via CallNonGenericMethod. I think we can instead change this to CheckedUnwrap.
|
Assignee | |
Comment 1•3 years ago
|
||
It's a cold code path, but this is simpler.
Changes ReportIncompatibleSelfHostedMethod to take a Value so that we can call
it here too, to produce the same error messages.
The cross-compartment wrapper code is tested by the builtin-exec-wrapper.js jit-test
that was added in bug 1831314 part 3.
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88aea7fbf651
Avoid calling back into self-hosted code in RegExpExec. r=iain
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox115:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•