1832416 - Update Material Components to version 1.9.0

Status: VERIFIED FIXED

(Firefox for Android :: General, task)

Description

[Ryan VanderMeulen [:RyanVM]]

Focus is currently on v1.7.0, but AC/Fenix are on v1.2.1. Release note links below:

• https://github.com/material-components/material-components-android/releases/tag/1.3.0
• https://github.com/material-components/material-components-android/releases/tag/1.4.0
• https://github.com/material-components/material-components-android/releases/tag/1.5.0
• https://github.com/material-components/material-components-android/releases/tag/1.6.0
• https://github.com/material-components/material-components-android/releases/tag/1.7.0
• https://github.com/material-components/material-components-android/releases/tag/1.8.0
• https://github.com/material-components/material-components-android/releases/tag/1.9.0

Updating to v1.9.0 was mostly painless in CI, though I did have to add an explicit dependency for androidx.drawerlayout due to that being added as a library dependency back in v1.5.0. Without that, I was seeing the below build failures:

ERROR:/builds/worker/checkouts/vcs/android-components/components/browser/session-storage/build/intermediates/incremental/debugAndroidTest/mergeDebugAndroidTestResources/merged.dir/values/values.xml:2930: AAPT: error: style attribute 'attr/drawerLayoutStyle (aka mozilla.components.browser.session.storage.test:attr/drawerLayoutStyle)' not found.
ERROR:/builds/worker/checkouts/vcs/android-components/components/browser/session-storage/build/intermediates/incremental/debugAndroidTest/mergeDebugAndroidTestResources/merged.dir/values/values.xml:3117: AAPT: error: style attribute 'attr/drawerLayoutStyle (aka mozilla.components.browser.session.storage.test:attr/drawerLayoutStyle)' not found.
ERROR:/builds/worker/checkouts/vcs/android-components/components/browser/session-storage/build/intermediates/incremental/debugAndroidTest/mergeDebugAndroidTestResources/merged.dir/values/values.xml:3313: AAPT: error: style attribute 'attr/drawerLayoutStyle (aka mozilla.components.browser.session.storage.test:attr/drawerLayoutStyle)' not found.
ERROR:/builds/worker/checkouts/vcs/android-components/components/browser/session-storage/build/intermediates/incremental/debugAndroidTest/mergeDebugAndroidTestResources/merged.dir/values/values.xml:3500: AAPT: error: style attribute 'attr/drawerLayoutStyle (aka mozilla.components.browser.session.storage.test:attr/drawerLayoutStyle)' not found.

I think my bigger concern is functional regressions from this change, as I remember very well the problems we had when we last updated Focus (bug 1811549). Though maybe that was tied more to updating appcompat. Regardless, I'd be very interested to know what, if any, QA testing would be good for this change? It also seems to me that we should aim to land this soon so we can get nearly a full Nightly cycle and all of Beta to flush out any major regressions.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1832416 - Update Material Components to version 1.9.0 (#1979)

Comment 2

[Mihai Adrian Carare [:mcarare]]

I think the only variant for this would be a full run. We use so many components from the material library and we use default values for some of them. It makes reviewing the PR difficult, because there are too many changes, and it also makes identifying components/features that should be tested by QA even harder.
It does help to have it for a longer time in Nightly so issues would be observed inherently by testing other things.

Comment 3

[BMO Github Automation]

Authored by https://github.com/rvandermeulen
https://github.com/mozilla-mobile/firefox-android/commit/b94f53473c3d8240eb74048651068fd3ec4a6cac
[main] Bug 1832416 - Update Material Components to version 1.9.0

Comment 4

[Mira Lobontiu (Android QA)]

Verified on the 115.0a1 Fenix Nightly builds from 5/15, and 5/16 with Google Pixel 6 (Android 13).
I've ran a smoke test suite covering the following areas:

• homescreen, task continuity, wallpapers,
• navigation toolbar, menus,
• downloads,
• search engines, search settings, search groups,
• browsing normal, and private mode, inactive tabs,
• audio/video playing, PiP mode,
• Firefox account, and sync.