1832476 - When the Spaces bar is hidden on dark themes, all items in the Spaces Menu have the same icon.

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Michel]

Attachment: Screenshot of the Spaces Menu

Select/install a dark theme, click bottom left |<- button to hide the Spaces Toolbar, then click top left Spaces button for the Spaces Menu. The Spaces button icon is used for all menu items.

Possible cause & fix:

On line 38 of chrome://messenger/content/webextensions.css there is the following rule:

  @media (prefers-color-scheme: dark) {
    :root .spaces-addon-menuitem,
    :root .spaces-popup-menuitem,
    .webextension-action {
      list-style-image: var(--webextension-toolbar-image-light, inherit) !important;
    }

    :root .spaces-addon-button img {
      content: var(--webextension-toolbar-image-light, inherit) !important;
    }
  }

The !important keywords here force not just the light icon but also the inheriting of the parent icon and therefore all icons are replaced by the Spaces icon.

When the !important keywords are removed it works OK, I don't think they are necessary, @media overrules the default anyway, but maybe I'm missing something.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1832476 - Remove the .spaces-popup-menuitem styles from webextensions.css. r=#thunderbird-front-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5ab34c7e4766
Remove the .spaces-popup-menuitem styles from webextensions.css. r=elizabeth

Comment 3

[Wayne Mery (:wsmwk)]

Comment on attachment 9333138 [details]
Bug 1832476 - Remove the .spaces-popup-menuitem styles from webextensions.css. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 4

[Rob Lemley [:rjl]]

Thunderbird 114.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/562ebe4b89b9