1832507 - The “Pocket_Onboarding” impression ping is displayed in the Browser Console without having a New Tab opened

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Alice Varro [avarro], Ecosystem QA]

Attachment: screen recording impression

[Affected versions]:

• Firefox Nightly 115.0a1 - FR, IT and es-ES locales (Build ID: 20230510213701)
• Firefox Beta 114.0b2 - FR, IT and es-ES locales (Build ID: 20230509180058)

[Affected Platforms]:

• Windows 10x64.
• macOS 12.6
• Linux Mint 20.2

[Prerequisites]:

• Have a Firefox FR, IT or es-ES locale installed.
• Have “browser.ping-centre.log” pref set to true.
• Have “browser.search.region” pref set to "IT", "FR" or "ES".

[Steps to reproduce]:

1. Open the browser from the prerequisites with a new profile.
2. Navigate to the “about:preferences” page and enable the “Open previous windows and tabs” option from the Startup section.
3. Open a few tabs and navigate to different websites.
4. Close the browser and reopen it.
5. Open the Browser Console (Ctrl/Cmd + Shift + J) and observe the displayed pings.

[Expected result]:

• There are no impression pings related to “Pocket_Onboarding” displayed in the Browser Console.

[Actual result]:

• A “Pocket_Onboarding” impression ping is displayed in the Browser Console.

[Notes]:

• Attaching a screen recording of the issue:

Comment 1

[Scott [:thecount] Downe]

Confirmed

Comment 2

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]:

Comment 3

[Scott [:thecount] Downe]

Attachment: Bug 1832507 - Pocket newtab fixng new markets onboarding dialog telemetry from firing in offscreen preloaded tabs

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox114 (beta). However, the bug still has low severity.

:tspurway, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 5

[Scott [:thecount] Downe]

I think severity 3 is appropriate. I don't think this need to be increased. I also think an uplift for this would be helpful for properly understanding the data when we launch.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c2bb65351a2
Pocket newtab fixng new markets onboarding dialog telemetry from firing in offscreen preloaded tabs r=gvn

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7c2bb65351a2

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:thecount, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Alice Varro [avarro], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly 115.0a1 (Build ID: 20230516042430), FR, IT and es-ES locales on Windows 10x64, macOS 12.6 and Linux Mint 20.2 and I can confirm that no "Pocket_Onboarding" impression ping is displayed without having a NewTab opened.

Comment 10

[Scott [:thecount] Downe]

Comment on attachment 9333388 [details]
Bug 1832507 - Pocket newtab fixng new markets onboarding dialog telemetry from firing in offscreen preloaded tabs

Beta/Release Uplift Approval Request

• User impact if declined: Telemetry issue
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open the browser from the prerequisites with a new profile.
  Navigate to the “about:preferences” page and enable the “Open previous windows and tabs” option from the Startup section.
  Open a few tabs and navigate to different websites.
  Close the browser and reopen it.
  Open the Browser Console (Ctrl/Cmd + Shift + J) and observe the displayed pings.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a bit of code, but not a lot.

However, it's unlikely to break anything, the likely risk scenario is the fix just doesn't work, which puts us where we are already.

• String changes made/needed: None
• Is Android affected?: No

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9333388 [details]
Bug 1832507 - Pocket newtab fixng new markets onboarding dialog telemetry from firing in offscreen preloaded tabs

Approved for 114 beta 8, thanks.

Comment 12

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/e7acf997f15c

Comment 13

[Alice Varro [avarro], Ecosystem QA]

I have verified this issue using the latest Firefox Beta 114.0b8 (Build ID: 20230523183658), FR, IT and es-ES locales on Windows 10x64, macOS 13.2 and Linux Mint 20.2 and I can confirm that no "Pocket_Onboarding" impression ping is displayed without having a NewTab opened.