Closed Bug 1832578 Opened 1 year ago Closed 1 year ago

Don't warn about options_ui.browser_style when options_ui.open_in_tab is true

Categories

(WebExtensions :: Frontend, enhancement)

enhancement

Tracking

(firefox114 fixed, firefox115 fixed)

RESOLVED FIXED
115 Branch
Tracking Status
firefox114 --- fixed
firefox115 --- fixed

People

(Reporter: robwu, Assigned: robwu)

References

Details

(Whiteboard: [addons-jira])

Attachments

(1 file)

When options_ui.open_in_tab is true, the value of options_ui.browser_style is not used. To avoid unnecessary logspam (deprecation warnings), let's add an extra check for open_in_tab

browser_style is only relevant when options_ui.open_in_tab is false or unspecified (in that case, the inline options browser at about:addons is used, which injects the style at https://searchfox.org/mozilla-central/rev/32c74afbb24dce4b5dd6b33be71197e615631d71/toolkit/mozapps/extensions/content/aboutaddons.js#1833-1835).

Assignee: nobody → rob
Status: NEW → ASSIGNED
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/dd7d36a3436a
Don't warn about browser_style if open_in_tab=true r=rpl
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch

Comment on attachment 9333098 [details]
Bug 1832578 - Don't warn about browser_style if open_in_tab=true

Beta/Release Uplift Approval Request

  • User impact if declined: Minor logspam: an unnecessary deprecation warning is printed when a Manifest Version 3 extension uses options_ui.open_in_tab = true without browser_style:false. The deprecation warning was added in 114 (currently Beta).
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Very specific change in extension code, covered by unit tests.
  • String changes made/needed: None
  • Is Android affected?: No
Attachment #9333098 - Flags: approval-mozilla-beta?

Comment on attachment 9333098 [details]
Bug 1832578 - Don't warn about browser_style if open_in_tab=true

Approved for 114 beta 5, thanks.

Attachment #9333098 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: