1832578 - Don't warn about options_ui.browser_style when options_ui.open_in_tab is true

Status: RESOLVED FIXED

(WebExtensions :: Frontend, enhancement)

Description

[Rob Wu [:robwu]]

When options_ui.open_in_tab is true, the value of options_ui.browser_style is not used. To avoid unnecessary logspam (deprecation warnings), let's add an extra check for open_in_tab

browser_style is only relevant when options_ui.open_in_tab is false or unspecified (in that case, the inline options browser at about:addons is used, which injects the style at https://searchfox.org/mozilla-central/rev/32c74afbb24dce4b5dd6b33be71197e615631d71/toolkit/mozapps/extensions/content/aboutaddons.js#1833-1835).

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1832578 - Don't warn about browser_style if open_in_tab=true

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd7d36a3436a
Don't warn about browser_style if open_in_tab=true r=rpl

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/dd7d36a3436a

Comment 4

[Rob Wu [:robwu]]

Comment on attachment 9333098 [details]
Bug 1832578 - Don't warn about browser_style if open_in_tab=true

Beta/Release Uplift Approval Request

• User impact if declined: Minor logspam: an unnecessary deprecation warning is printed when a Manifest Version 3 extension uses options_ui.open_in_tab = true without browser_style:false. The deprecation warning was added in 114 (currently Beta).
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very specific change in extension code, covered by unit tests.
• String changes made/needed: None
• Is Android affected?: No

Comment 5

[Pascal Chevrel:pascalc]

Comment on attachment 9333098 [details]
Bug 1832578 - Don't warn about browser_style if open_in_tab=true

Approved for 114 beta 5, thanks.

Comment 6

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/22b87680da84