Closed Bug 1832711 Opened 2 years ago Closed 2 years ago

Using dependencySubstitutions for GV causing 2 dependencies and broken indexing

Categories

(Firefox for Android :: General, defect)

All
Android
defect

Tracking

()

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: zmckenney, Assigned: zmckenney)

Details

Attachments

(1 file)

After the monorepo migration, when attempting to use local GV in Fenix indexing does not work properly and will often not show changes made in local GV. This is due to an unknown dependency pulling the nightly GV along with the local GV (which is part of a larger investigation currently happening). Using a local Maven fixes the issue and Fenix will only have 1 GV dependency.

Due to future changes to the monorepo and GV dependencies which may fix this issue, I recommend we update the readme for showing developers how to use local maven instead of dependencySubstitution.

Fixing and updating the current doc for substitutions and linking that in the readme is probably the best approach:
fenix/docs/substituting-local-ac-and-gv.md

Assignee: nobody → zmckenney

Authored by Zac McKenney
https://github.com/mozilla-mobile/firefox-android/commit/10da214ab14945500bdbfd644a1bfbd3926d7cac
[main] Bug 1832711 - Update readme and docs for how to use local GV in Fenix

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch

Hello Zac,

Is QA verification needed for this issue? If so, could you please provide us with some steps to reproduce (STR) or testing scenarios?

Thank you!

Flags: needinfo?(zmckenney)

There is no need for QA verification here.
I'll remove the qe-verify+ flag.

Flags: needinfo?(zmckenney)
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: