Closed Bug 1832720 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 39975 - [GridNG] Opposite direction last indefinite index

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
115 Branch
Tracking Flags:
Tracking Status
firefox115 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39975 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39975
Details from upstream follow.

Kurt Catti-Schmidt <kschmi@microsoft.com> wrote:

[GridNG] Opposite direction last indefinite index

This CL fixes several issues with opposite-direction nested subgrids in
auto-sized tracks. First, the last_indefinite_index array needs to be
reversed. We can't simply reverse the array, since it's an array of
prior indices. Ethan suggested a clever idea, which is to rebuild the
array by looking at when the parent array changed in subsequent values,
as that's how it's originally built up.

The second issue this fixes is that the extra margin for contribution
sizes needs to swap the start and end offsets.

A new test was added that's a variation of
writing-directions-002.html but with auto track sizes.

Bug: 618969
Change-Id: I495daa34e3c0c0cadd5f25d7a9212641c05bb81d

Reviewed-on: https://chromium-review.googlesource.com/4506078
WPT-Export-Revision: dc0074a31e5a5cb7aec627310e8b7be8907c6c75

Component: web-platform-tests → Layout: Grid
Product: Testing → Core
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9e711d682922 [wpt PR 39975] - [GridNG] Opposite direction auto track subgrid fixes, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/9e711d682922

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox115: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.