1832751 - Cherry-pick libwebrtc fixes to webrtc::SequenceChecker for Mac

Status: RESOLVED FIXED

(Core :: WebRTC, task, P2)

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1832751 - cherry-pick upstream libwebrtc commit 3da04a93cd. r?webrtc-reviewers

Upstream commit: https://webrtc.googlesource.com/src/+/3da04a93cd18dc7b65c6756910cc8a9cbf20fb8c
Allow SequenceChecker to be initialized detached.

The motivation for this is to not have to implement this pattern:

foo.h:

class Foo {
 public:
  Foo();
 private:
  SequenceChecker checker_;
};

foo.cc:

Foo::Foo() {
  checker_.Detach();
}

And instead be able to do this inline in the .h file:

class Foo {
 public:
  Foo();
 private:
  SequenceChecker checker_{SequenceChecker::kDetached};
};

Bug: none
Change-Id: Idd7ca82d15c2f77f3aaccf26f1943a49f4b40661
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/298445
Reviewed-by: Danil Chapovalov <[e-mail]>
Commit-Queue: Tomas Gunnarsson <[e-mail]>
Cr-Commit-Position: refs/heads/main@{#39616}

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1832751 - cherry-pick upstream libwebrtc commit 301e546a68. r?webrtc-reviewers

Upstream commit: https://webrtc.googlesource.com/src/+/301e546a689020320f919a660591759e993ef051
Remove SequenceCheckerImpl::valid_system_queue_

As pointed out in issue webrtc:15146 this Mac/iOS specific variable,
makes the SequenceChecker behave incorrectly on those platforms.

The variable was introduced in a CL that merged the previous checker
classes, ThreadChecker and SequencedTaskChecker, but curiously neither
one of them had such a variable. So I'm not exactly sure what problem
was being solved. Hence I'm wondering if we actually need it.

Reference: https://webrtc-review.googlesource.com/c/src/+/129721

Bug: webrtc:15146
Change-Id: Ia7a9eb17b993c4f8a1e8204c658bf0b3dbdaa1e0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304401
Reviewed-by: Peter Hanspers <[e-mail]>
Commit-Queue: Tomas Gunnarsson <[e-mail]>
Cr-Commit-Position: refs/heads/main@{#40019}

Comment 3

[Michael Froman [:mjf]]

Attachment: Bug 1832751 - add no-op tracking files for cherry-picked commits. r?pehrsons!

Comment 4

[Michael Froman [:mjf]]

I've opened a bug to (at least) create a script to help write the no-op tracking files, Bug 1832854.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/757b62d9ee50
cherry-pick upstream libwebrtc commit 3da04a93cd. r=webrtc-reviewers,mjf
https://hg.mozilla.org/integration/autoland/rev/220fde5226ae
cherry-pick upstream libwebrtc commit 301e546a68. r=webrtc-reviewers,mjf
https://hg.mozilla.org/integration/autoland/rev/7aa33449d313
add no-op tracking files for cherry-picked commits. r=pehrsons,webrtc-reviewers

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/757b62d9ee50
https://hg.mozilla.org/mozilla-central/rev/220fde5226ae
https://hg.mozilla.org/mozilla-central/rev/7aa33449d313