1832834 - Make `--backgroundtask backgroundupdate` work with unelevated installations [SERVICE_REGISTRY_KEY_MISSING]

Status: RESOLVED FIXED

(Toolkit :: Application Update, enhancement, P3)

Description

[Max Christian Pohle [:/dev/max]]

The initial background update landing does not schedule the background update task when a permission elevation is denied during the setup and aborts with a SERVICE_REGISTRY_KEY_MISSING error.

With this bug we are going to land a change to allow background update for these users, which is going to require unprecedented tests to ensure that this works and keeps working reliably.

Comment 1

[Robin Steuber (she/her) [:bytesized]]

I don't understand how this is meant to work. Are we going to use the Service even though the registry key is missing? Are we going to show a UAC prompt from a background task?

Comment 2

[Max Christian Pohle [:/dev/max]]

The idea is, that we can already upgrade some and perhaps most installations without the need for a UAC prompt, e.g. because these were installed under %LOCALAPPDATA%\Mozilla Firefox. The implementation will somehow check if we can write to the target location and if that is the case, it is going to behave as if you had set app.update.background.force.

Comment 3

[Max Christian Pohle [:/dev/max]]

Attachment: Bug 1832834 - Add Nimbus feature to allow background updates for unelevated installations. r=bytesized,nalexander

Comment 4

[Max Christian Pohle [:/dev/max]]

Attachment: WIP: Bug 1832834 - part 1, r=nalexander

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: WIP: Bug 1832834 - Part 1: Add Nimbus feature to allow background updates for unelevated installations. r=nalexander

This feature allows to schedule and install background updates even
when the Mozilla Maintenance Service is not configured for an
installation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2aed50c0b2e6
Add Nimbus feature to allow background updates for unelevated installations. r=nalexander,application-update-reviewers,bytesized

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out changeset 2aed50c0b2e6 (Bug 1832834) for causing xpcsheel failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=OYHhtit5SsaVkEDLwSXf9w.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=2aed50c0b2e6297a989f8c8e064ab107bb8c76e0

Log: https://treeherder.mozilla.org/logviewer?job_id=422718680&repo=autoland&lineNumber=2262
https://treeherder.mozilla.org/logviewer?job_id=422718680&repo=autoland&lineNumber=2262
https://treeherder.mozilla.org/logviewer?job_id=422717884&repo=autoland&lineNumber=2281

Backout: https://hg.mozilla.org/integration/autoland/rev/2fa0f2941257f51a55bcabee0f1913fe395266b0

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbea40f618ed
Add Nimbus feature to allow background updates for unelevated installations. r=nalexander,application-update-reviewers,bytesized

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bbea40f618ed

Comment 10

[Max Christian Pohle [:/dev/max]]

Attachment: Bug 1832834 - Fixed typo in experiment name, r=nalexander

Comment 11

[Max Christian Pohle [:/dev/max]]

changed:

allowUpdatesForUnelevatedInstallions
allowUpdatesForUnelevatedInstallations

local tests passed, manual test passed, treeherder run here

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac98a0d8a999
Fixed typo in experiment name, r=nalexander,application-update-reviewers

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ac98a0d8a999