1832850 - Tidy up nursery header in preparation for inlining nursery allocation

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P1)

Description

[Jon Coppeard (:jonco)]

This bug is for a series of patches to tidy up gc/Nursery.h in preparation for inlining more of nursery allocation.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1832850 - Part 1: Move NurseryDecommitTask definition to gc/Nursery.cpp r?jandem

This is never used anywhere else as so don't need to be in the header.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1832850 - Part 2: Move nursery string deduplication set to TenuringTracer r?jandem

This moves the set and its associated hasher class into TenuringTracer. This is
a good place given the lifetime of the set.

The also moves TenuringTracer to the js::gc namespace.

Depends on D177927

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1832850 - Part 3: Remove an unnecessary include and some unnecessary forward declarations from gc/Nursery.h r?jandem

Depends on D177928

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1832850 - Part 4: Remove the option to write canaries between nursery allocations r?jandem

To my knowledge this has never caught any bugs so let's remove it in the name
of simplicity.

Depends on D177929

Comment 5

[Jon Coppeard (:jonco)]

Attachment: Bug 1832850 - Part 5: Move the allocateObject definition into gc/Nursery.h r?jandem

In line with allocateString and allocateBigInt, this definition can easily be
moved to the header.

Depends on D177930

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a3e8db962f6
Part 1: Move NurseryDecommitTask definition to gc/Nursery.cpp r=jandem
https://hg.mozilla.org/integration/autoland/rev/6a902c32f8aa
Part 2: Move nursery string deduplication set to TenuringTracer r=jandem
https://hg.mozilla.org/integration/autoland/rev/9017faa7167b
Part 3: Remove an unnecessary include and some unnecessary forward declarations from gc/Nursery.h r=jandem
https://hg.mozilla.org/integration/autoland/rev/17d8991c1621
Part 4: Remove the option to write canaries between nursery allocations r=jandem
https://hg.mozilla.org/integration/autoland/rev/3e0a5d26dc60
Part 5: Move the allocateObject definition into gc/Nursery.h r=jandem
https://hg.mozilla.org/integration/autoland/rev/dcf5abb28a14
apply code formatting via Lando

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3d8a8edf9b0
Backed out 6 changesets for causing SM bustages. CLOSED TREE

Comment 8

[Cosmin Sabou [:CosminS]]

Backed out for causing SM bustages.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=sm&revision=dcf5abb28a147961d06a936703e82ae5d1e4219b&selectedTaskRun=J-bplvwwQtK9xn_1AYK8nA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=416357492&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/e3d8a8edf9b080f710157b7252e0ab237434bed0

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbfec9cb12fd
Part 1: Move NurseryDecommitTask definition to gc/Nursery.cpp r=jandem
https://hg.mozilla.org/integration/autoland/rev/ac0b7cb87ee5
Part 2: Move nursery string deduplication set to TenuringTracer r=jandem
https://hg.mozilla.org/integration/autoland/rev/d5d8026c16f2
Part 3: Remove an unnecessary include and some unnecessary forward declarations from gc/Nursery.h r=jandem
https://hg.mozilla.org/integration/autoland/rev/ea024fc5269d
Part 4: Remove the option to write canaries between nursery allocations r=jandem
https://hg.mozilla.org/integration/autoland/rev/bcedbd32e29f
Part 5: Move the allocateObject definition into gc/Nursery.h r=jandem

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/cbfec9cb12fd
https://hg.mozilla.org/mozilla-central/rev/ac0b7cb87ee5
https://hg.mozilla.org/mozilla-central/rev/d5d8026c16f2
https://hg.mozilla.org/mozilla-central/rev/ea024fc5269d
https://hg.mozilla.org/mozilla-central/rev/bcedbd32e29f