1832997 - X button is invisible on light theme

Status: RESOLVED DUPLICATE of bug 1796209

(Firefox for Android :: Tabs, defect, P3)

Description

[eclaudiu64]

Attachment: mobizen_20230514_002609_001.mp4

User Agent: Mozilla/5.0 (Android 11; Mobile; rv:109.0) Gecko/114.0 Firefox/114.0

Steps to reproduce:

I entered the Facebook account login link on another application.

Actual results:

I entered a semi open tab and the X button is not visible on the light theme mode of the phone. X button is on white color on white (light) theme.

Expected results:

X button should be black on light theme.

Comment 1

[Noah Bond [:007]]

This is potentially caused by the default color for CustomTabsToolbarFeature.readableColor being Color.White, or CustomTabConfig. We should try to use one of our color system tokens instead.

Comment 2

[Noah Bond [:007]]

Hey :eclaudiu, thank you for your patience with this. The engineering team is working through a larger prioritization effort right now, and breathing some fresh air into Custom Tabs is on that list. I'm adding the "good-first-bug" keyword to this in case a community member wants to pick this bug up, but it's our hope to give Custom Tabs, as a whole, some love when we have the bandwidth.