183302 - null plugin doesn't save mime types

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Felix Miata]

2002120213 OS/2 trunk, but not new.

To reproduce:
1-Don't have the plugin installed
2-Open a page using an uninstalled plugin
3-Dismiss the dialog asking if you want to download the plugin (answer no)
4-Reopen the same or another page using the same plugin

Actual behavior:
1-Popup asks if you want to download the plugin

Expected behavior:
1-Mozilla remembers you don't want that plugin and proceeds without imposing
another unnecessary popup

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Fix

Add code to write to OS2.INI each time we see a new mime type so we don't keep
asking.

Comment 2

[Felix Miata]

Why not save in mozilla/bin/plugins/os2store.rdf, $HOME/localstore.rdf, or
$HOME/os2store.rdf? Why does the desktop need to store data personal to an app?

Comment 3

[Mike Kaply [:mkaply]]

I new you were going to ask that. :)

The null plugin is basically a standalone application. It can't access Mozilla 
preferences, RDF or anything.

There is another bug for making the null plugin a part of Mozilla at which time 
that info could be stored in Mozilla datastores.

So for now I have to store it in an OS/2 INI file and I don't want to create a 
new INI file just for the null plugin.

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 108096 [details] [diff] [review]
Fix

sr would be blizzard as this is platform specific code.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 108096 [details] [diff] [review]
Fix

a=asa for checkin to 1.3a. It needs to land today if it's going to make it.

Comment 6

[Mike Kaply [:mkaply]]

Fix checked in.

Comment 7

[Felix Miata]

Did this miss AM but make PM in today's builds.

Comment 8

[Felix Miata]

No plugin popups in over a week. Must be fixed. v.