1833031 - Address book filter (search) interferes with editing and access to contacts

Status: VERIFIED FIXED

(Thunderbird :: Address Book, defect)

Description

[Wayne Mery (:wsmwk)]

Example 1

#1. In address book window, type zzz into the search field
#2. edit > find > search addresses
#3. enter critera to find an existing contact
#4. select a contact and click properties
Result: "No contacts found". Contact is not opened. If you remove step 1 it works

Example 2

#1. In address book window, type zzz into the search field
#2. in message list select a message whose contact exists in an address book
#3. click on contact to or from in message pane, and pick edit contact
Result: empty contact is presented. If you remove step 1 it works

Comment 1

[Wayne Mery (:wsmwk)]

Need to test on 102, but I'd expect it to reproduce there

Comment 2

[Wayne Mery (:wsmwk)]

Example 1 doesn't behave the same in 102, but that no longer matters.
Example 2 still reproduces in 117 beta.

It's annoying but an uncommon scenario and easily worked around, so S4

Comment 3

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1833031 - Clear address book search view in commands for displaying/editing contacts. r=#thunderbird-reviewers

r=#thunderbird-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/75e041cf333a
Clear address book search view in commands for displaying/editing contacts. r=darktrojan

Comment 5

[Wayne Mery (:wsmwk)]

I confirm this allows edit to work on nightly using the specified steps. But it does clear the user's search field entry, so I would consider this to be a workaround patch.

Comment 6

[Hartmut Welpmann [:welpy-cw]]

(In reply to Wayne Mery (:wsmwk) from comment #5)

I confirm this allows edit to work on nightly using the specified steps. But it does clear the user's search field entry, so I would consider this to be a workaround patch.

Yes, I understand that, but I suspect that a real solution would require architectural changes in the address book component ...

Comment 7

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9389213 [details]
Bug 1833031 - Clear address book search view in commands for displaying/editing contacts. r=#thunderbird-reviewers

[Approval Request Comment]
User impact if declined: see bug report
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Wayne Mery (:wsmwk)]

I can verify this works in nightly and beta.

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9389213 [details]
Bug 1833031 - Clear address book search view in commands for displaying/editing contacts. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 10

[Rob Lemley [:rjl]]

mail/components/addrbook/content/aboutAddressBookCommands.mjs does not exist on comm-esr115, this patch does not apply.

Comment 11

[Hartmut Welpmann [:welpy-cw]]

Attachment: D203507.esr115.diff

[Approval Request Comment]
This should apply to esr115. Because of the different code structure, it is correct that only one line is added.

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9395882 [details] [diff] [review]
D203507.esr115.diff

[Triage Comment]
Approved for esr115

thanks for the revision

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 115.10.0:
https://hg.mozilla.org/releases/comm-esr115/rev/48e8f29c0306