1833037 - Unable to open the "Recently Closed Windows" subview in the main menu in some cases

Status: RESOLVED FIXED

(Firefox :: Menus, defect, P1)

Description

[Itiel]

Regressed by bug 1832141. I'm.. not really sure what is the STR, but I confirmed this in a clean profile as well.
When this happens, I have already restored a session, and then I attempt to open that menu.

From the browser console:

TypeError: can't access property "l10n", this is undefined
RecentlyClosedTabsAndWindowsMenuUtils.sys.mjs:76:29
TypeError: can't access property "tagName", headerNode.nextSibling is null
    ensureHeaderSeparator resource:///modules/PanelMultiView.jsm:1397
    set headerText resource:///modules/PanelMultiView.jsm:1424
    _showSubView resource:///modules/PanelMultiView.jsm:743
    showSubView resource:///modules/PanelMultiView.jsm:674
    value resource:///modules/PanelMultiView.jsm:435
    showSubView chrome://browser/content/customizableui/panelUI.js:428
    oncommand chrome://browser/content/browser.xhtml:1

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1832141

:eemeli, since you are the author of the regressor, bug 1832141, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Eemeli Aro [:eemeli]]

Ah, I had not accounted for how this call pattern loses the this for the function. Will fix ASAP.

Comment 3

[Eemeli Aro [:eemeli]]

Attachment: Bug 1833037 - Do not depend on `this` in RecentlyClosedTabsAndWindowsMenuUtils. r=gijs!

Also remove public access to the internal Localization instance.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec17b45c0141
Do not depend on `this` in RecentlyClosedTabsAndWindowsMenuUtils. r=Gijs

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ec17b45c0141