Closed Bug 1833199 Opened 2 years ago Closed 2 years ago

Changes to FenixDependencies.kt and FocusDependencies.kt don't trigger external-gradle-dependencies rebuilds for their respective products

Categories

(Firefox Build System :: Task Configuration, defect)

Product:
Firefox Build System
Component:
Task Configuration
Platform:
Unspecified
Android
Type:
defect

Tracking

(firefox113 wontfix, firefox114 wontfix, firefox115 fixed)

Status:
RESOLVED FIXED
Milestone:
115 Branch
Tracking Flags:
Tracking Status
firefox113 --- wontfix
firefox114 --- wontfix
firefox115 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

Details

Attachments

(1 file)

[mozilla-mobile/firefox-android] Bug 1833199 - Ensure that changes to Fenix & Focus dependencies rebuild the gradle cache (#2044)
59 bytes, text/x-github-pull-request
Details | Review

I've encountered this a few times recently when attempting to bump a dependency in one of those files and getting mass build failures because the external-gradle-dependencies job wasn't being scheduled in the graph. The only workaround was making a change to the android-components DependenciesPlugin.kt to force all of the cached dependendencies to be rebuilt.

Thankfully I have a fix ready to go that I've tested and confirmed triggers the expected rebuilds to the right products!

Authored by https://github.com/rvandermeulen
https://github.com/mozilla-mobile/firefox-android/commit/62dad3ae07d00c6afd227db3ee1ebae825d0d272
[main] Bug 1833199 - Ensure that changes to Fenix & Focus dependencies rebuild the gradle cache

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox115: --- → fixed
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
status-firefox113: --- → wontfix
status-firefox114: --- → wontfix
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: