Closed Bug 1833233 Opened 3 years ago Closed 3 years ago

Fix hardcoded sqlite database header in ObfuscatingVFS.cpp to allow incremental_vacuum for fixed page size databases

Categories

(Core :: Storage: IndexedDB, defect, P2)

defect

Tracking

()

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: hsingh, Assigned: hsingh)

References

Details

Attachments

(2 external files, 1 obsolete file)

First reported in https://bugzilla.mozilla.org/show_bug.cgi?id=1832639, incremental_vacuum is not working properly on fixed page size (encrypted sqlite db) databases. This is because we use hard-coded database header for encrypted databases (https://searchfox.org/mozilla-central/source/storage/ObfuscatingVFS.cpp#320-325) and one of the properties (at offset 52 of 100 bytes header) is not getting set properly (see sqlite db file format: https://www.sqlite.org/fileformat.html).

Solution with sample code is captured: https://sqlite.org/mozilla/forumpost/d76c83dc5d

Assignee: nobody → hsingh
Status: NEW → ASSIGNED
See Also: → 1833141
Severity: -- → S3
Priority: -- → P2
Attachment #9333804 - Attachment is obsolete: true
Pushed by hsingh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0d47305d972a Fix incremental vacuum on encrypted sqlite IDB databases.r=dom-storage-reviewers,asuth

(In reply to Harveer Singh from comment #0)

Solution with sample code is captured: https://sqlite.org/mozilla/forumpost/d76c83dc5d

FYI, that forum is private, so it's not that useful to refer to that.

Keywords: leave-open
Keywords: leave-open
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d859f4cdad27 Add description for some database header fields; r=dom-storage-reviewers,hsingh,asuth
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: