183331 - Message Views feature: UI Nits

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[jglick]

http://www.mozilla.org/mailnews/specs/views/

1. Message Views dialog. Horizontal alignment is off. Descriptive text appears
to be very high at the top of the dialog and there is a lot of extra space below
the OK/Cancel/Help buttons.

2. Message Views dialog. Descriptive text needs work. Robin, could use your
feedback on this one. Does the dialog need descriptive text? "Select or create a
custom view".? 

3. Message View Setup dialog. "When this view is selected, display only messages
that" (remove "match").

4. Feature needs to be accessible from the Menus.
http://www.mozilla.org/mailnews/specs/views/index.html#Menus

Comment 1

[robinf]

Feedback on #2:

Suggested title text for Message Views dialog: "Customize Message Views"

I don't think this dialog needs descriptive text. 

Comment 2

[(not reading, please use [e-mail] instead)]

I've gotten some private emails about other nits, I'll add them to this bug.

thanks jen.

Comment 3

[jglick]

Thanks Robin.

2. Message Views dialog. Removed descriptive text at top of dialog. Change 
dialog title to Customize Message Views.

Comment 4

[(not reading, please use [e-mail] instead)]

nits from [e-mail]:

> o If you have a "Match any of the following" list of criteria for a view,
>    save it, then re-edit the view it gets changed to a "Match all of the
>    following" list of criteria in the Message View Setup window.
>
> o New mail in IMAP folders tends to have an empty "Status" on my system
>    until I "touch" the messages.  So a filter that looks like:
>
>     Match any of the following:
>     the Status is Unread
>     or the Label is Important
>
>    does not show new messages.  It seems to work for the Inbox.  I have
>    many but not all of my folders marked as "Check this folder for new
>    messages" since I filter'n'file with an external agent.  There's
>    no "match if the status is empty" choice so using a "Match any of the
>    following" list there's no way to have a view that is "Unread or
>    Important" with this "blank status" bug.


o When returning to the "All" view the view isn't scrolled following the same
rules as before: if sort by date then the newest messages are visible, etc.. 
(bugzilla #80608).

Comment 5

[Samir Gehani]

Mail triage team: nsbeta1+/adt2

Comment 6

[[e-mail]]

Attachment: Fix the scrolling issue

Comment 7

[[e-mail]]

Attachment: Fix the extra space issue

Comment 8

[(not reading, please use [e-mail] instead)]

Comment on attachment 114090 [details] [diff] [review]
Fix the extra space issue

r/sr=sspitzer on this one liner.  safe and small, and worth taking for 1.3
final, so seeking approval on neils behalf.

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 114090 [details] [diff] [review]
Fix the extra space issue

a=asa (on behalf of drivers) for checkin to 1.3 final.

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Reading the url mentioned in comment 0, please allow threading to work together
with views. not being able to show messages as threads when I select something
from the View dropdown makes this feature useless to me.

Comment 11

[[e-mail]]

Fix checked in.

Comment 12

[jglick]

Reopening.

Item #2. Per Robin's suggestions, the description text should be removed and the
title of the dialog should be changed.
http://www.mozilla.org/mailnews/specs/views/#MsgViews

Item #3. Message View Setup dialog. "When this view is selected, display only
messages that" (remove "match"). "Match" is already the first word in each of
the radio buttons dialog.

Item #4. Covered in bug 189543.

Comment 13

[[e-mail]]

Oops, sorry for resolving this, got carried away :-)

Comment 14

[(not reading, please use [e-mail] instead)]

fix in hand for item3 and item4.  patch coming...

Comment 15

[(not reading, please use [e-mail] instead)]

Attachment: fix two more UI nits

Comment 16

[(not reading, please use [e-mail] instead)]

fixed, since these two nits are fixed and the other issue is a new bug.

Comment 17

[(not reading, please use [e-mail] instead)]

re-opening, as neil's patch for

"o When returning to the "All" view the view isn't scrolled following the same
rules as before: if sort by date then the newest messages are visible, etc.. 
(bugzilla #80608)."

hasn't been reviewed or checked in.

Comment 18

[(not reading, please use [e-mail] instead)]

neils fix ties into bug #186504.

there is some duplicated code, and I bet the fix for #186504 would need to be
applied to searchBar.js, too.

let me go look at neils fix for #186504, and see if it can be factored out for
searchBar.js, too.

Comment 19

[(not reading, please use [e-mail] instead)]

Attachment: updated version of neil's fix.

Comment 20

[(not reading, please use [e-mail] instead)]

fixed, as a modified version of neil's fix for searchBar.js is checked in.

note, the "scrolling" issue isn't just a view issue, it's a quick search issue.

but that shouldn't be a surprise, as views are implement using QS.

to clarify, the "scrolling" issue is fixed when you clear a quick search, or if
you go from a message view back to the "all" view.

Comment 21

[Ninoschka Baca]

Trunk build 2003-04-10: WinXP, Mac 10.1.5
- Item 1: ok
- Item 2: ok
- Item 3: ok
- Item 4: still don't see the additional views in the Views menu
** - comment #4: bullet items 1 and 2 are ok, bullet item 3 works when switching
between a custom mail view and switching back to All but ** doesn't appear to
work via Quick Search**

Is this bug suppose to fix the Quick Search issue. If yes, then this bug should
be reopened.

Comment 22

[Ninoschka Baca]

Since the majority of the issues are resolved, marking this bug Verified.