1833333 - In `popover` IDL's getter steps return the "canonical" keyword

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

This is specified by https://html.spec.whatwg.org/#reflecting-content-attributes-in-idl-attributes:canonical-keyword-2.

Here it implies if some element's attribute value is the empty string, someElement.popover should equal "auto", because the canonical keyword (https://html.spec.whatwg.org/#canonical-keyword) for the empty string is "auto". Covered by a test (https://searchfox.org/mozilla-central/rev/f60cf6bfa8bd096efd9bb3a445364f5a0f32897a/testing/web-platform/tests/html/semantics/popovers/popover-attribute-basic.html#100,102).

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1833333: return the canonical keyword in `popover` IDL's getter steps. r=emilio

Covered by the sub-test at
https://searchfox.org/mozilla-central/rev/f60cf6bfa8bd096efd9bb3a445364f5a0f32897a/testing/web-platform/tests/html/semantics/popovers/popover-attribute-basic.html#100,102.
Verified locally that it passes with the patch and failed without it.
The whole test
(https://searchfox.org/mozilla-central/rev/f60cf6bfa8bd096efd9bb3a445364f5a0f32897a/testing/web-platform/tests/html/semantics/popovers/popover-attribute-basic.html#120)
still fails at a later stage, hence the meta data isn't changed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db52f0a08d84
return the canonical keyword in `popover` IDL's getter steps. r=emilio

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/db52f0a08d84