1833355 - [wpt-sync] Sync PR 40027 - webrtc: Add codec selection tests

Status: RESOLVED FIXED

(Core :: WebRTC, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 40027 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40027
Details from upstream follow.

Florent Castelli <[e-mail]> wrote:

webrtc: Add codec selection tests

Bug: 1442194
Change-Id: I619b986bf80dfdf0a8deb00516932570a778736f

Reviewed-on: https://chromium-review.googlesource.com/4536635
WPT-Export-Revision: 82d15682a340c106457ca334ee3e8624fc2c1635

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba7f7bf870d4619c74dccaffb14e6187d9e8c983

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 18 subtests

Status Summary

Firefox

OK : 1
PASS: 2
FAIL: 16

Chrome

OK : 1
PASS: 2
FAIL: 16

Safari

OK : 1
FAIL: 18

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webrtc-extensions/RTCRtpParameters-codec.html [wpt.fyi]
  • Creating an audio sender with addTransceiver and codec should work: FAIL (Chrome: FAIL, Safari: FAIL)
  • Creating a video sender with addTransceiver and codec should work: FAIL (Chrome: FAIL, Safari: FAIL)
  • Setting codec on an audio sender with setParameters should work: FAIL (Chrome: FAIL, Safari: FAIL)
  • Setting codec on a video sender with setParameters should work: FAIL (Chrome: FAIL, Safari: FAIL)
  • Creating an audio sender with addTransceiver and non-existing codec should throw OperationError: FAIL (Chrome: FAIL, Safari: FAIL)
  • Creating a video sender with addTransceiver and non-existing codec should throw OperationError: FAIL (Chrome: FAIL, Safari: FAIL)
  • Setting a non-existing codec on an audio sender with setParameters should throw InvalidModificationError: FAIL (Chrome: FAIL, Safari: FAIL)
  • Setting a non-existing codec on a video sender with setParameters should throw InvalidModificationError: FAIL (Chrome: FAIL, Safari: FAIL)
  • Setting a non-preferred codec on an audio sender with setParameters should throw InvalidModificationError: FAIL (Chrome: FAIL, Safari: FAIL)
  • Setting a non-preferred codec on a video sender with setParameters should throw InvalidModificationError: FAIL (Chrome: FAIL, Safari: FAIL)
  • Setting a non-negotiated codec on an audio sender with setParameters should throw InvalidModificationError: FAIL (Chrome: FAIL, Safari: FAIL)
  • Setting a non-negotiated codec on a video sender with setParameters should throw InvalidModificationError: FAIL (Chrome: FAIL, Safari: FAIL)
  • Codec should be undefined after negotiating away the currently set codec on an audio sender: FAIL (Chrome: FAIL, Safari: FAIL)
  • Codec should be undefined after negotiating away the currently set codec on a video sender: FAIL (Chrome: FAIL, Safari: FAIL)
  • Stats output-rtp should match the selected codec in non-simulcast usecase on an audio sender: FAIL (Chrome: FAIL, Safari: FAIL)
  • Stats output-rtp should match the selected codec in non-simulcast usecase on a video sender: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3acf5c49906
[wpt PR 40027] - webrtc: Add codec selection tests, a=testonly
https://hg.mozilla.org/integration/autoland/rev/007f06523c1c
[wpt PR 40027] - Update wpt metadata, a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a3acf5c49906
https://hg.mozilla.org/mozilla-central/rev/007f06523c1c