1833495 - Blocked ads are sometimes recorded as visible ads

Status: VERIFIED FIXED

(Firefox :: Search, task, P2)

Description

[James Teow [:jteow]]

I used an adblocker and I noticed some ads were recorded as visible when they shouldn't have been.

We should investigate why that is. It's easily reproducible which shows that we must make the algorithm for checking if an element exists more resilient.

Comment 1

[James Teow [:jteow]]

For some elements on some SERPs, sometimes the element will have a dimension but be well beyond the content area (e.g. far above the HTML element) upon load.

Comment 2

[James Teow [:jteow]]

Attachment: Bug 1833495 - Check if an ad is well above the possible viewable window - r?standard8,scunnane

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43b46464c43a
Check if an ad is well above the possible viewable window - r=Standard8

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/43b46464c43a

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 9339443 [details]
Bug 1833495 - Check if an ad is well above the possible viewable window - r?standard8,scunnane

Beta/Release Uplift Approval Request

• User impact if declined: Improvement to new Search SERP Ad telemetry that we would like to turn on a bit earlier. Improves reporting of the visible/non-visible state of ads.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Change to analysis/telemetry reporting only. Well tested code.
• String changes made/needed: None
• Is Android affected?: No

Comment 6

[Donal Meehan [:dmeehan]]

Comment on attachment 9339443 [details]
Bug 1833495 - Check if an ad is well above the possible viewable window - r?standard8,scunnane

Approved for 115.0.2
Approved for 115.0.2esr

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/721cc3e6f209

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/fe13597792dc

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/f001fe269389

Comment 10

[Adrian Florinescu [:aflorinescu]]

Verfied as fixed with Fx115.0.2ESR, 115.0.2, Fx116.0b4, 117.0a1 (2023-07-10) on Windows 10, Ubuntu 22.04 and Mac 13.