Closed Bug 1833495 Opened 1 year ago Closed 1 year ago

Blocked ads are sometimes recorded as visible ads

Categories

(Firefox :: Search, task, P2)

task

Tracking

()

VERIFIED FIXED
116 Branch
Tracking Status
firefox-esr115 --- verified
firefox115 --- verified
firefox116 --- verified
firefox117 --- verified

People

(Reporter: jteow, Assigned: jteow)

References

Details

Attachments

(1 file)

I used an adblocker and I noticed some ads were recorded as visible when they shouldn't have been.

We should investigate why that is. It's easily reproducible which shows that we must make the algorithm for checking if an element exists more resilient.

Blocks: 1813160

For some elements on some SERPs, sometimes the element will have a dimension but be well beyond the content area (e.g. far above the HTML element) upon load.

Assignee: nobody → jteow
Status: NEW → ASSIGNED
Pushed by jteow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43b46464c43a
Check if an ad is well above the possible viewable window - r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch

Comment on attachment 9339443 [details]
Bug 1833495 - Check if an ad is well above the possible viewable window - r?standard8,scunnane

Beta/Release Uplift Approval Request

  • User impact if declined: Improvement to new Search SERP Ad telemetry that we would like to turn on a bit earlier. Improves reporting of the visible/non-visible state of ads.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Change to analysis/telemetry reporting only. Well tested code.
  • String changes made/needed: None
  • Is Android affected?: No
Attachment #9339443 - Flags: approval-mozilla-release?

Comment on attachment 9339443 [details]
Bug 1833495 - Check if an ad is well above the possible viewable window - r?standard8,scunnane

Approved for 115.0.2
Approved for 115.0.2esr

Attachment #9339443 - Flags: approval-mozilla-release? → approval-mozilla-release+
Attachment #9339443 - Flags: approval-mozilla-esr115+

Verfied as fixed with Fx115.0.2ESR, 115.0.2, Fx116.0b4, 117.0a1 (2023-07-10) on Windows 10, Ubuntu 22.04 and Mac 13.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: