1833516 - [wpt-sync] Sync PR 40039 - [anchor-position] Fix anchor-scroll resolving name conflicts

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 40039 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40039
Details from upstream follow.

Xiaocheng Hu <[e-mail]> wrote:

[anchor-position] Fix anchor-scroll resolving name conflicts

anchor-scroll resolves anchor names with NGPhysicalAnchorQuery, which
however keeps only one of the anchors of the same name, causing
incorrect anchor-scroll behavior when there are name conflicts.

This patch makes NGPhysialAnchorQuery to keep the entire list of same
name anchors (like its logical counterpart), and then only propagate
the first one to NGLogicalAnchorQuery.

Fixed: 1441210
Change-Id: Ib85c651e2767ae27b316609917e207da32def2a2
Reviewed-on: https://chromium-review.googlesource.com/4529222
WPT-Export-Revision: 8e4ad4aad8e25170f5ec2f781f6e814dddadc92a

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4370d60c4e95690bca2f7a5ca24ae605516de4f7

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

OK : 1
FAIL: 4

Chrome

OK : 1
PASS: 2
FAIL: 2

Safari

OK : 1
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-anchor-position/anchor-scroll-002.html [wpt.fyi]
  • target1 should scroll with anchor1: FAIL (Chrome: PASS, Safari: FAIL)
  • target2 should scroll with anchor2: FAIL (Chrome: FAIL, Safari: FAIL)
  • target3 should scroll with anchor3: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-anchor-position/anchor-scroll-001.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36b91bba81a9
[wpt PR 40039] - [anchor-position] Fix anchor-scroll resolving name conflicts, a=testonly
https://hg.mozilla.org/integration/autoland/rev/feb5bc4a9155
[wpt PR 40039] - Update wpt metadata, a=testonly

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/36b91bba81a9
https://hg.mozilla.org/mozilla-central/rev/feb5bc4a9155