Closed Bug 1833524 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 40042 - Revert "Improve hover triggering functionality to support popover=manual"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox115 fixed)

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream error])

Sync web-platform-tests PR 40042 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40042
Details from upstream follow.

Nate Chapin <japhet@chromium.org> wrote:

Revert "Improve hover triggering functionality to support popover=manual"

This reverts commit e4cde2ad20aac0ace162db28090bc421df2e7e76.

Reason for revert: Compile break: https://ci.chromium.org/ui/p/chromium/builders/ci/lacros64-archive-rel/53380/overview

Original change's description:

Improve hover triggering functionality to support popover=manual

This CL primarily adds a much larger hover hiding test, which tests
all popover types, two invoker types, and all popovertargetaction
values. In building that, I found a number of cases that weren't
properly handled, mostly because hover detection was using a version
of IsNodePopoverDescendant that was fairly manual and old. This
new version makes better use of a newly-expanded
FindTopmostRelatedPopover which is able to optionally look at manual
popovers. In doing this, I also refactored the inclusive argument
into an EnumSet to allow controlling the manual popover behavior
at the same time.

Bug: 1416284
Fixed: 1443372
Fixed: 1445580
Change-Id: I2370610b4c7517fa635c353f0cfaf6de7b16b3af
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4505324
Commit-Queue: Mason Freed \<masonf@chromium.org>
Auto-Submit: Mason Freed \<masonf@chromium.org>
Reviewed-by: Joey Arhar \<jarhar@chromium.org>
Commit-Queue: Joey Arhar \<jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1144968}

Bug: 1416284
Change-Id: I6ed5ce2f3b7ace980838cf8e0106ecc3a5fb9cc1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4540744
Owners-Override: Nate Chapin \<japhet@chromium.org>
Reviewed-by: Joey Arhar \<jarhar@chromium.org>
Commit-Queue: Nate Chapin \<japhet@chromium.org>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1144983}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/14184bd2331a [wpt PR 40042] - Revert "Improve hover triggering functionality to support popover=manual", a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.