1833555 - Use AutoTemplateContext machinery to produce concrete results for OverloadExpr

Status: RESOLVED FIXED

(Webtools :: Searchfox, enhancement)

Description

[Botond Ballo [:botond]]

For CXXDependentScopeMemberExpr, we produce both heuristic results and, using the AutoTemplateContext machinery, concrete results.

For OverloadExpr, we currently only produce heuristic results. We could use the AutoTemplateContext machinery to produce concrete results as well.

This would only make sense to do after bug 1833552 is implemented, because in the case of OverloadExpr, the concrete results would strictly be a subset of the heuristic results, so it only makes sense to generate them if we're going to do something beyond just a straight merge with the heuristic results (which would be a no-op).

Comment 1

[Nicolas Guichard]

Attachment: GitHub Pull Request

Comment 2

[Nicolas Guichard]

Attachment: Bug 1833555 - Mark OverloadExpr locations to be visited in instantiations. r?asuth!

Now that the context menu allows for differentiating between heuristic
and concrete template instantiations, mark OverloadExpr location to be
visited in AnalyzeDependent mode to have concrete results.

In the added WithOverloads::Overloaded test case, the float and bool
overloads are only found heuristically (and are thus marked with
cppTemplateHeuristic) while the int overload is also found by visiting
concrete template instantiations.

This is a bump of the Mozsearch clang plugin and was reviewed upstream:
https://github.com/mozsearch/mozsearch/pull/844

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee62c8f7cd64
Mark OverloadExpr locations to be visited in instantiations. r=asuth

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ee62c8f7cd64