Closed
Bug 1833617
Opened 11 months ago
Closed 10 months ago
getCSSDeclarationBlockIssues should handle multiple dom rules at once
Categories
(DevTools :: Inspector: Rules, task)
DevTools
Inspector: Rules
Tracking
(firefox115 fixed)
RESOLVED
FIXED
115 Branch
Tracking | Status | |
---|---|---|
firefox115 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
Attachments
(1 file)
At the moment, for the compatibility tooltip, there's a call to getCSSDeclarationBlockIssues for each dom rule
If a page has a lot of rules, this can trigger a lot of RDP requests and slow down the inspector.
We should be able to get the data for multiple rules at once
Assignee | ||
Comment 1•11 months ago
|
||
Previously, we were calling getCssDeclarationBlockIssues
for each dom rule.
This was causing performance issue when displaying a lot of rules as we'd make
almost concurrent RDP calls.
In this patch, we make CompatibilityActor#getCssDeclarationBlockIssues
take
an array of dom rule declarations, so we can get the data for multiple rules at once.
From the client, we throttle calls to the RDP method so we can effectively batch
the request.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/22ae1ee910f9 [devtools] Batch calls to retrieve rules compatibility issues. r=jdescottes,devtools-backward-compat-reviewers,devtools-reviewers.
Comment 3•10 months ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
status-firefox115:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•