Closed Bug 1833725 Opened 2 years ago Closed 2 years ago

Preview button is incorrectly shown if Phabricator token is present

Categories

(Conduit :: Lando, defect, P3)

Product:
Conduit
Component:
Lando
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1801959

People

(Reporter: zeid, Unassigned)

Details

(Keywords: conduit-triaged, good-first-bug)

If a selected revision or stack has landed, the equivalent Lando page should show a greyed out "Landing blocked" button. However, if a user has their Phabricator token in Lando, a green "Preview Landing" button is shown instead. Nonetheless, a "Landing is blocked" message with "Reason for blockage is unknown" is shown in the landing preview modal.

I added this as a quick fix to keep the Request uplift button available on revisions which have already landed in autoland. We should fix this properly, probably by resolving bug 1801959.

Status: NEW → RESOLVED
Closed: 2 years ago
Duplicate of bug: 1801959
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.