1833809 - Simultaneous playback of Reddit videos in Firefox causes unresponsiveness

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Simona Badau, Desktop QA]

Attachment: about:support

Found in

• Nightly 115.0a1

Affected versions

• Nightly 115.0a1
• Firefox 114 beta 5

Tested platforms

• Affected platforms: Windows 10

Steps to reproduce

1. Open a new tab and play this Reddit video
2. Open another tab and start playing the Reddit video simultaneously.

Expected result

• Both videos should play properly at the same time.

Actual result

• When playing the two videos simultaneously, Firefox becomes unresponsive.

Regression range
Found commit message:
Bug 1831329 - Block FEATURE_HW_DECODED_VIDEO_ZERO_COPY with Driver Version: 20.19.15.4390 r=gfx-reviewers,ErichDonGubler

Additional notes

• This is a follow-up for Bug 1831329.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:sotaro, since you are the author of the regressor, bug 1831329, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Sotaro Ikeda [:sotaro]]

Hi Simona, thank you for reporting the bug! Can you check if either of the following pref changes could address the problem? Each pref change needs to restart Firefox.

• [1] gfx.direct3d11.reuse-decoder-device = false
• [2] media.hardware-video-decoding.enabled = false
• [3] gfx.webrender.dcomp-video-overlay-win = false

Comment 3

[Simona Badau, Desktop QA]

(In reply to Sotaro Ikeda [:sotaro] from comment #2)

Hi Simona, thank you for reporting the bug! Can you check if either of the following pref changes could address the problem? Each pref change needs to restart Firefox.

• [1] gfx.direct3d11.reuse-decoder-device = false

With this pref set to false, the videos play properly and Firefox is not unresponsive.

• [2] media.hardware-video-decoding.enabled = false

This also helps, multiple videos can be played simultaneously and there is no unresponsiveness.

• [3] gfx.webrender.dcomp-video-overlay-win = false

Setting this to false does not help, Firefox becomes unresponsive when 2 videos are played simultaneously.

Comment 4

[Sotaro Ikeda [:sotaro]]

Great! Thank you for checking. It seems better to block FEATURE_REUSE_DECODER_DEVICE as in Bug 1831329 comment 6.

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1833809 - Block FEATURE_REUSE_DECODER_DEVICE with Intel Skylake

Comment 6

[Sotaro Ikeda [:sotaro]]

Hi Simona, can you check if the following build of D178607 blocks FEATURE_REUSE_DECODER_DEVICE in about:support and addresses the problem for you?

https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/P7x1mMWQQ8SoDoI7if9lzw/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=P7x1mMWQQ8SoDoI7if9lzw.0&revision=31a5c1825302a3234d12fc73d08c6e40126f3852

Comment 7

[Simona Badau, Desktop QA]

(In reply to Sotaro Ikeda [:sotaro] from comment #6)

Hi Simona, can you check if the following build of D178607 blocks FEATURE_REUSE_DECODER_DEVICE in about:support and addresses the problem for you?

https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/P7x1mMWQQ8SoDoI7if9lzw/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=P7x1mMWQQ8SoDoI7if9lzw.0&revision=31a5c1825302a3234d12fc73d08c6e40126f3852

Yes, on this build - the FEATURE_REUSE_DECODER_DEVICE is blocked in about:support, and there is no unresponsiveness when playing multiple Reddit videos.

Comment 8

[Sotaro Ikeda [:sotaro]]

Great! Thank you.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/920e3eb99be8
Block FEATURE_REUSE_DECODER_DEVICE with Intel Skylake r=gfx-reviewers,lsalzman

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/920e3eb99be8

Comment 11

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9335154 [details]
Bug 1833809 - Block FEATURE_REUSE_DECODER_DEVICE with Intel Skylake

Beta/Release Uplift Approval Request

• User impact if declined: Simultaneous playback of Reddit videos with Intel HD Graphics 530 of Driver Version: 20.19.15.4390 causes Firefox unresponsive.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change just adds blocklist of FEATURE_REUSE_DECODER_DEVICE.
• String changes made/needed: none
• Is Android affected?: No

Comment 12

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9335154 [details]
Bug 1833809 - Block FEATURE_REUSE_DECODER_DEVICE with Intel Skylake

Approved for 114 beta 9, thanks.

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/3cfe660d155c

Comment 14

[Simona Badau, Desktop QA]

Verified as fixed on the latest Nightly 115.0a1 and Firefox 114.0b9 - tested on a Windows 10 machine with Intel HD Graphics 530 of Driver Version: 20.19.15.4390.