1833935 - Ctrl+Shift+F does not show search UI when left panel is collapsed

Status: VERIFIED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Timothy C. Quinn]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/113.0

Steps to reproduce:

To search for sources in debugger, I always have used the Ctrl+Shift+F shortcut but it stopped working recently.

When in Debugger, I clicked on Ctrl+Shift+F

Actual results:

Nothing happens

Expected results:

The Search dialog UI should be brought into focus so I can type in my query.

Comment 1

[Timothy C. Quinn]

OS: Ubuntu 22.04 (fully updated)
X: KDE Plasma 5.24.7 (X11)

I have tried new Profiles and Private windows and get the same result.

I also tested on a several Windows server VMs and have the same issue. They are running Firefox 113.x also.

The expected behavior should be to expand the new search pane on the left and focus on the search box when ctrl+shift+F is typed in Debugger panel.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Thanks for the report
Can you tell us if there are error messages in the Browser Console (https://firefox-source-docs.mozilla.org/devtools-user/browser_console/index.html) when you try to open the search panel?

Comment 3

[Timothy C. Quinn]

Just verified on my main Ubuntu 22.04 dev environment and no messages showing up in Browser Console when I hit the keys ctrl+shift+F. Same goes for Windows Server 2019.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: CleanShot 2023-05-23 at 08.00.49.png

Thanks for checking. Is the focus in the debugger? Also, the search in all files features was moved into a side panel on the left, can you confirm it's not displayed when you hit the keyboard shortcut?
If not, do you see the side panel and can you access it clicking on its title?

I think I just found an issue: if the left panel is collapsed, then the keyboard shortcut does not work. Is this the case you're seeing?

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

:bomsy, since you are the author of the regressor, bug 1811000, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1833935 - [devtools] Open left sidebar when triggering project search. r=bomsy.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1811000

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a6c3bf93a6d
[devtools] Open left sidebar when triggering project search. r=bomsy,devtools-reviewers.

Comment 9

[Julian Descottes [:jdescottes]]

Might be worth uplifting

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1a6c3bf93a6d

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nchevobbe, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9335387 [details]
Bug 1833935 - [devtools] Open left sidebar when triggering project search. r=bomsy.

Beta/Release Uplift Approval Request

• User impact if declined: Project search in debugger won't work if user collapsed debugger left sidebar
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open the debugger (on any page)

1. Hide the left sidebar if it's visible
2. Hit Ctrl+Shift+F (Cmd+Shift+F on OSX)

-> left sidebar should open and search UI should be visible

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): simple, devtools change only, covered by mochitest
• String changes made/needed:
• Is Android affected?: No

Comment 13

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9335387 [details]
Bug 1833935 - [devtools] Open left sidebar when triggering project search. r=bomsy.

Approved for 114 beta 9, thanks.

Comment 14

[Pascal Chevrel (relman team) -> :pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/db93e8d82834

Comment 15

[Alexandru Trif, Desktop Test Engineering [:atrif]]

I have reproduced the issue with Firefox 115.0a1 (2023-05-18) on Windows 10x64. The Ctrl + Shift + F keyboard shortcut does nothing inside the debugger while the left Sidebar is collapsed.
I can no longer reproduce the issue at least when doing this first time with Firefox 115.0a1 (2023-05-25) and 114.0b9 on Windows 10x64, macOS 12, and Ubuntu 20.04. The Ctrl + Shift + F keyboard shortcut correctly opens the left sidebar with the search UI displayed.

However, if I collapse the sidebar again and try to open it by using the Ctrl + Shift + F keyboard shortcut this does not work. Should we file another issue for this or reopen this one? Thank you!

Comment 16

[Nicolas Chevobbe [:nchevobbe]]

good catch! Let's open a new bug for it

Comment 17

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #16)

good catch! Let's open a new bug for it

Thank you! I filled in bug 1835238. Closing this as verified per comment 15 and comment 16.