1833982 - Perma Windows MinGW all [tier 2] /builds/worker/checkouts/gecko/widget/windows/filedialog/WinFileDialogCommands.cpp:9:10: fatal error: 'shobjidl_core.h' file not found

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Treeherder Bug Filer]

Filed by: imoraru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=416331019&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Sd4sQXnlTxadKGMm84mWjQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2023-05-19T02:07:12.837Z] 02:07:12     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/widget/windows/filedialog'
[task 2023-05-19T02:07:12.840Z] 02:07:12     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/x86_64-w64-mingw32-clang++ -Qunused-arguments -o Unified_cpp_windows_filedialog0.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -ftrivial-auto-var-init=pattern -DDEBUG=1 -DUNICODE -D_UNICODE -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DOS_WIN=1 -DWIN32 -D_WIN32 -D_WINDOWS -DWIN32_LEAN_AND_MEAN -DWINAPI_NO_BUNDLED_LIBRARIES -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/widget/windows/filedialog -I/builds/worker/workspace/obj-build/widget/windows/filedialog -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -fno-sized-deallocation -fno-aligned-new -fms-extensions -fcrash-diagnostics-dir=/builds/worker/artifacts -D_HAS_EXCEPTIONS=0 -fno-exceptions -Wno-incompatible-ms-struct -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -gcodeview -O2 -fno-omit-frame-pointer -funwind-tables -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wenum-compare-conditional -Wenum-float-conversion -Wno-ambiguous-reversed-operator -Wno-error=deprecated -Wno-error=deprecated-anon-enum-enum-conversion -Wno-error=deprecated-enum-enum-conversion -Wno-error=deprecated-pragma -Wno-error=deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wno-unknown-pragmas -Wno-unused-function -Wno-conversion-null -Wno-switch -Wno-enum-compare -Wno-psabi -Wthread-safety -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/Unified_cpp_windows_filedialog0.o.pp   Unified_cpp_windows_filedialog0.cpp
[task 2023-05-19T02:07:12.840Z] 02:07:12     INFO -  In file included from Unified_cpp_windows_filedialog0.cpp:2:
[task 2023-05-19T02:07:12.841Z] 02:07:12     INFO -  /builds/worker/checkouts/gecko/widget/windows/filedialog/WinFileDialogCommands.cpp:9:10: fatal error: 'shobjidl_core.h' file not found
[task 2023-05-19T02:07:12.841Z] 02:07:12     INFO -  #include <shobjidl_core.h>
[task 2023-05-19T02:07:12.841Z] 02:07:12     INFO -           ^~~~~~~~~~~~~~~~~
[task 2023-05-19T02:07:12.841Z] 02:07:12     INFO -  1 error generated.
[task 2023-05-19T02:07:12.841Z] 02:07:12    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:670: Unified_cpp_windows_filedialog0.o] Error 1
[task 2023-05-19T02:07:12.841Z] 02:07:12     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/widget/windows/filedialog'
[task 2023-05-19T02:07:12.842Z] 02:07:12     INFO -  gmake[4]: Target 'target-objects' not remade because of errors.
[task 2023-05-19T02:07:12.842Z] 02:07:12    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: widget/windows/filedialog/target-objects] Error 2
[task 2023-05-19T02:07:12.848Z] 02:07:12     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/xpcom/components'

Comment 1

[Iulian Moraru]

Hi Ray! Can you please take a look at this?
Thank you!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1833450

Comment 3

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1833982 - [1/1] Fix MinGW builds r?cmartin,gstoll,handyman

MinGW builds don't have <shobjidl_core.h>, but do have <shobjidl.h>.
Substitute appropriately.

Comment 4

[Ray Kraesig [:rkraesig]]

Green try run: https://treeherder.mozilla.org/jobs?repo=try&revision=f5bf26c18d2bfb9dc34f201cd0d8ff8b7ae98c34

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aff5c7ec1028
[1/1] Fix MinGW builds  r=gstoll

Comment 6

[Intermittent Failures Robot]

17 failures in 529 pushes (0.032 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 8
• mozilla-central: 9

Platform and build breakdown:

• windows-mingw32: 17
  • all: 17

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1833982&startday=2023-05-19&endday=2023-05-19&tree=all

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/aff5c7ec1028

Comment 8

[Intermittent Failures Robot]

17 failures in 3578 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 8
• mozilla-central: 9

Platform and build breakdown:

• windows-mingw32: 17
  • all: 17

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1833982&startday=2023-05-15&endday=2023-05-21&tree=all