[CtW] Remove unnecessary differentiation between Local and Remote Accessibles in platform specific code
Categories
(Core :: Disability Access APIs, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox115 | --- | fixed |
People
(Reporter: Jamie, Assigned: Jamie)
References
Details
(Whiteboard: [ctw-postship])
Attachments
(2 files)
Now that most methods are unified in Accessible, we mostly don't need different code paths for LocalAccessible and RemoteAccessible. There are still a few of these left in Mac and ATK code; e.g. here (we can use nsAccUtils::DocumentFor), here (we can just call mGeckoAccessible->ActionCount), here (use nsAccUtils::DocumentFor), here (just call Accessible::Bounds), here (use Accessible::ChildAt), etc. There are a few instances of password masking specific to LocalAccessible in ATK code that I'm pretty sure we can remove, but we should double check both local and remote password fields with Orca.
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Comment 1•1 year ago
|
||
|
|
Assignee | |
Comment 2•1 year ago
|
||
The core, cross-platform implementation already masks passwords.
Thus, the ATK specific code has been unnecessary for a long time now.
The ATK masking code also only applied to LocalAccessible.
This means we can get rid of this differentiation between local and remote.
Pushed by jteh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/28e49b4d529a part 1: Remove several unnecessary differentiations between local and remote Accessibles in platform specific code. r=morgan https://hg.mozilla.org/integration/autoland/rev/d6b35539db67 part 2: Remove ATK specific password masking code. r=morgan
|
||
Comment 4•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/28e49b4d529a
https://hg.mozilla.org/mozilla-central/rev/d6b35539db67
Description
•