1834066 - Update Search Engine URL for Gule sider

Status: VERIFIED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

The integrated engine Gule sider has changed its URL so we need to update it.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1834066 - Update Search Engine URL for Gule sider. r?#search-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f309cd80c10d
Update Search Engine URL for Gule sider. r=search-reviewers,daleharvey

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 9335042 [details]
Bug 1834066 - Update Search Engine URL for Gule sider. r?#search-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: Users attempting to use the application provided Gule sider will find it doesn't work correctly.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Load up one of the nn-* locales of Firefox & run a search from the address bar using the Gule sider search engine.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Update to URLs only.
• String changes made/needed: None
• Is Android affected?: No

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 9335042 [details]
Bug 1834066 - Update Search Engine URL for Gule sider. r?#search-reviewers!

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Fixes a broken application provided search engine
• User impact if declined: Users attempting to use the application provided Gule sider search engine will find it doesn't work correctly.
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Update to URLs only.

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f309cd80c10d

Comment 6

[Adrian Florinescu [:aflorinescu]]

Verified as fixed with 115.0a1 (2023-05-21) on Windows 10, Ubuntu 22.04 and Mac 11.7.4 as follows:

• default engine
• address bar + default engine
• search mode
• search bar + default engine

search example: https://www.gulesider.no/search_string/bedrifter , locale nn-NO.

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9335042 [details]
Bug 1834066 - Update Search Engine URL for Gule sider. r?#search-reviewers!

Approved for 114 beta 8, thanks.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0ab9f6d941d9

Comment 9

[Ryan VanderMeulen [:RyanVM]]

This doesn't graft cleanly to ESR and I'm not entirely sure what the right approach is for rebasing it.

Comment 10

[Mark Banner (:standard8)]

Attachment: Bug 1834066 - Update Search Engine URL for Gule sider. (ESR) r=search-reviewers,daleharvey

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 9335445 [details]
Bug 1834066 - Update Search Engine URL for Gule sider. (ESR) r=search-reviewers,daleharvey

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Fixes a broken application provided search engine
• User impact if declined: Users attempting to use the application provided Gule sider search engine will find it doesn't work correctly.
• Fix Landed on Version: 114
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Update to URLs only.

Comment 12

[Adrian Florinescu [:aflorinescu]]

Verified as fixed with 114.0b8 on Windows 10, Ubuntu 22.04 and Mac 11.7.4 as follows:

default engine
address bar + default engine
search mode
search bar + default engine
context menu search + default engine
search example: https://www.gulesider.no/search_string/bedrifter , locale nn-NO.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9335445 [details]
Bug 1834066 - Update Search Engine URL for Gule sider. (ESR) r=search-reviewers,daleharvey

Approved for 102.12esr.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/9a587b87adb2

Comment 15

[Adrian Florinescu [:aflorinescu]]

Verified as fixed with 102.12.0esr on Windows 10, Ubuntu 22.04 and Mac 11.7.4 as follows:

default engine
address bar + default engine
search mode
search bar + default engine
context menu search + default engine
search example: https://www.gulesider.no/search_string/bedrifter , locale nn-NO.

One note to have here is that there is a visible transition through: https://www.gulesider.no/search?what=all&cmpid=fre_partner_fire_gssbtop&q=dsadasdsa , but i don't think there any concern since the search pull through