1834272 - [wpt-sync] Sync PR 40121 - WIP: do not cache CCNS page if WebRTC/Transport/Socket used

Status: RESOLVED FIXED

(Core :: Networking: WebSockets, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 40121 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40121
Details from upstream follow.

Mingyu Lei <[e-mail]> wrote:

WIP: do not cache CCNS page if WebRTC/Transport/Socket used

In the current implementation, if the WebRTC/WebTransport/Websocket
connections are closed, the non-sticky feature will be removed and the
page will be eligible for BFCache.
However, the page may contain some sensitive data that are retrieved
over these channels before the connection closure, so we should not
store the CCNS page into BFCache.

This CL also create kAllowedForNonCacheControlNoStoreFeatures for
those features that are allowed for non-CCNS page BFCache, and moved
kAuthorizationHeader over.

This CL is WIP since the tests are not added yet.

Bug: 1446619
Change-Id: Ic2e1e49d50fe522b1a66c6e011cb6fa83670d05d
Reviewed-on: https://chromium-review.googlesource.com/4549039
WPT-Export-Revision: d6f656818dd85ca174b71050fefcc863ec025060

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c42bfb13aeb1531aa8cc3907cd8e84d0ebb336d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 1 subtests

Status Summary

Firefox

OK : 4[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 6[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub]
PRECONDITION_FAILED: 4[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 6[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub]

Chrome

OK : 6
PRECONDITION_FAILED: 6

Safari

OK : 6
FAIL : 2
PRECONDITION_FAILED: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webrtc/back-forward-cache-with-closed-webrtc-connection-ccns.https.tentative.window.html [wpt.fyi]
  • Testing BFCache support for page with closed WebRTC connection and "Cache-Control: no-store" header.: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED, Safari: PRECONDITION_FAILED)
• /webrtc/back-forward-cache-with-open-webrtc-connection-ccns.https.tentative.window.html [wpt.fyi]
  • Testing BFCache support for page with open WebRTC connection and "Cache-Control: no-store" header.: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED, Safari: PRECONDITION_FAILED)
• /websockets/back-forward-cache-with-closed-websocket-connection-ccns.tentative.window.html [wpt.fyi]
  • Testing BFCache support for page with closed WebSocket connection and "Cache-Control: no-store" header.: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED, Safari: FAIL)
• /websockets/back-forward-cache-with-open-websocket-connection-ccns.tentative.window.html [wpt.fyi]
  • Testing BFCache support for page with open WebSocket connection and "Cache-Control: no-store" header.: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED, Safari: FAIL)
• /webtransport/back-forward-cache-with-closed-webtransport-connection-ccns.https.tentative.window.html [wpt.fyi]: OK [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: OK)
  • Testing BFCache support for page with closed WebTransport connection and "Cache-Control: no-store" header.: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED, Safari: PRECONDITION_FAILED)
• /webtransport/back-forward-cache-with-open-webtransport-connection-ccns.https.tentative.window.html [wpt.fyi]: OK [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: OK)
  • Testing BFCache support for page with open WebTransport connection and "Cache-Control: no-store" header.: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED, Safari: PRECONDITION_FAILED)

Tests Disabled in Gecko Infrastructure

• /webtransport/back-forward-cache-with-closed-webtransport-connection-ccns.https.tentative.window.html [wpt.fyi]: OK [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: OK)
• /webtransport/back-forward-cache-with-open-webtransport-connection-ccns.https.tentative.window.html [wpt.fyi]: OK [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: OK)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f80757edf45c
[wpt PR 40121] - CCNS BFCache: do not cache CCNS page if WebRTC/Transport/Socket used, a=testonly
https://hg.mozilla.org/integration/autoland/rev/8a320658e81d
[wpt PR 40121] - Update wpt metadata, a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f80757edf45c
https://hg.mozilla.org/mozilla-central/rev/8a320658e81d