1834662 - Port Bug 1793557 - Use our own addons.properties and brand.properties in aboutAddonsExtra.js

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Alessandro Castellani [:aleca]]

Just a couple of eslint issues with those bundles not being available anymore.
https://treeherder.mozilla.org/logviewer?job_id=416788663&repo=comm-central&lineNumber=260

Comment 1

[solange]

Attachment: Bug 1834662 - Port Bug 1793557: Use our own addons.properties and brand.properties in aboutAddonsExtra.js. r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7e30e71042eb
Port Bug 1793557: Use our own addons.properties and brand.properties in aboutAddonsExtra.js. r=mkmelin DONTBUILD

Comment 3

[Magnus Melin [:mkmelin]]

There's more work to be ported. I'll look at that now.

Comment 4

[Rob Wu [:robwu]]

(In reply to Magnus Melin [:mkmelin] from comment #3)

There's more work to be ported. I'll look at that now.

See https://phabricator.services.mozilla.com/D158663#inline-984230 and the "Thunderbird" part of the comment. The code suggested in that comment has been adopted and can be viewed at https://searchfox.org/mozilla-central/source/toolkit/components/extensions/ExtensionPermissionMessages.sys.mjs . Feel free to tag me for review or feedback in a patch if you need more help.

Comment 5

[Magnus Melin [:mkmelin]]

Thanks. We unfortunately have a whole heap of semi-forked code that need to be adjusted/synced. And strings that need to be moved to Fluent to operate without hacks at least. I think.

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: Bug 1834662 - Make test_ext_permission_warnings.js work for Thunderbird. r=robwu

Thunderbird shouldn't be special cased here. This is testing toolkit behavior.

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: Bug 1834662 - Port Convert ExtensionsUI.jsm strings to Fluent to Thunderbird. r=john.bieling

This is syncing a lot of semi-forked code.
Much of the duplicated strings from Firefox are not needed anymore. Still need to look at Fluent migrations.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d49f009b89ad
Make test_ext_permission_warnings.js work for Thunderbird. r=robwu

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: Bug 1834662 - Migrate calendar enable button to Fluent. r=#thunderbird-reviewers

Nothing more permantent than a temporary fix...

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d49f009b89ad

Comment 11

[John Bieling (:TbSync)]

Attachment: Bug 1834662 - Remove unused code in ExtensionsUI.jsm. r=#thunderbird-reviewers

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/abdc4863371d
Migrate calendar enable button to Fluent. r=leftmostcat

Comment 13

[Intermittent Failures Robot]

1 failures in 3946 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• lint: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1834662&startday=2023-05-22&endday=2023-05-28&tree=all

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1a55e2c03721
Port Convert ExtensionsUI.jsm strings to Fluent to Thunderbird. r=john.bieling
https://hg.mozilla.org/comm-central/rev/334119edb763
Remove unused code in ExtensionsUI.jsm. r=mkmelin