1834747 - [ally] Talkback is unable to identify 'privacy notice' link in Juno Onboarding's Content

Status: VERIFIED FIXED

(Firefox for Android :: Onboarding, defect)

Description

[Adina Petridean QA [:apetridean]]

Prerequisites

Fresh install Firefox app.

Steps to reproduce

1. Turn TalkBack on.
2. Launch Fenix.
3. From the Juno Onboarding tap on "privacy notice" link.
4. Observe the behaviour.

Expected behavior

When double tapping on the "Learn more in our privacy notice'", Talkback reads the text and allows access to the web page.

Actual behaviour
When double-tapping on the "Learn more in our privacy notice" (this sentence is read aloud with "Firefox puts people over profits and defends your privacy by blocking cross-site trackers"), the link https://www.mozilla.org/en-US/privacy/firefox/ cannot be accessed.

Devices name
Samsung GalaxyZ Fold 4
Motorola Moto G9 plus

Android version
Android 13, (Android 11)

Firefox release type
Firefox Nightly

Comment 1

[Adina Petridean QA [:apetridean]]

Attachment: privacy notice.mp4

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1834747 - Fix talkback linktext access url issue (#2370)

Comment 3

[BMO Github Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/5efc8b5327679d039ebc7f8f4d4b69d07b0e9c46
[main] Bug 1834747 - Fix talkback linktext access url issue

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:rsainani, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox115 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Rahul Sainani [:rsainani]]

Thanks, when it's verified by QA, I will nominate it for beta uplift.

Comment 6

[Adina Petridean QA [:apetridean]]

Verified as fixed on Nightly 116.0a1 from 06/09 with Motorola Moto G9 plus (Android 11). When double tapping on the "privacy notice'", Talkback reads the text and allows access to the web page.

Comment 7

[Adina Petridean QA [:apetridean]]

Attachment: privacyNotice.mp4

Comment 8

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1834747 - Fix talkback linktext access url issue (backport #2370) (#2419)

Comment 9

[Rahul Sainani [:rsainani]]

Comment on attachment 9338605 [details] [review]
[mozilla-mobile/firefox-android] Bug 1834747 - Fix talkback linktext access url issue (backport #2370) (#2419)

Beta/Release Uplift Approval Request

• User impact if declined: Privacy notice would not be clickable on onboarding to talkback enabled users
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Mentioned in the bug above.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It fixes a small functionality for talkback enabled users, other users are not impacted
• String changes made/needed: no
• Is Android affected?: Yes

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9338605 [details] [review]
[mozilla-mobile/firefox-android] Bug 1834747 - Fix talkback linktext access url issue (backport #2370) (#2419)

Approved for Fenix 115.0b5.

Comment 11

[BMO Github Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/21290bd65c29ab7b68e9dc11e1ff3c57763f73ee
[releases_v115] Bug 1834747 - Fix talkback linktext access url issue

Comment 12

[Andrei Mocirean]

Verified as fixed on the latest Nightly (116.0a1) from 14th of June 2023.
Device used for testing: Google Pixel 7 Pro (Android 13)

Comment 13

[Rahul Sainani [:rsainani]]

Andrei, it was already verified on 116, did you mean to write that it's verified on 115 beta as well?

Comment 14

[Andrei Mocirean]

Hello,
I am sorry for the misunderstanding, I've somehow overlooked the comment from Adina. However, regarding the Beta status, we are trying to verify this issue on Firefox Beta 115.0b5 but we are facing some issues, as the Juno Onboarding is not enabled by default and we can't seem to find an experiment targeting the Beta channel, only the release targeted one is present.
Is there something we are missing here?
Thanks!

Comment 15

[Delia Pop (Android QA)]

Attachment: screenshot-1687342488508.png

Verified as Fixed on Beta 115.0b8. We were able to verify that the Talkback now reads the "privacy notice" link and the website can be accessed by double tapping the link using the nimbus CLI tool to enroll in the on-boarding-challenge-the-default experiment.
Devices used for testing:

• Samsung Galaxy A53 5G (Android 13)
• Huawei P40 Lite (Android 10)
• Sony Xperia (Android 6.0.1)

Comment 16

[Rahul Sainani [:rsainani]]

Great, thanks!