Closed Bug 1834816 Opened 2 years ago Closed 2 years ago

Move DelazifyTask to FrontendContext

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
117 Branch
Tracking Status
firefox117 --- fixed

People

(Reporter: nbp, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Currently the DelazifyTask uses a JSRuntime* pointer to access the delazificationCache which is stored on the JSRuntime.

This might causes problems for moving the ParseTask to be independent of the JS engine, as the DelazifyTask can be initialized at the end of a ParseTask.

What I would recommend would be to have an optional StencilCache* pointer as argument of the ParseTask and DelazificationTask as a replacement for the JSRuntime*, and assert that only in cases where a DelazifyTask is created that the delazificationCache pointer is non-null.

Severity: -- → S3
Priority: -- → P3
Depends on: 1843944
Depends on: 1843956
Depends on: 1843973
Depends on: 1843976
Depends on: 1843978
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/9ae887198cb8 Part 1: Remove JSContext* parameter from FrontendContext-variant of DelazifyCanonicalScriptedFunction. r=nbp https://hg.mozilla.org/integration/autoland/rev/3cf9b59b655c Part 2: Do not touch TlsContext in DelazifyTask. r=nbp https://hg.mozilla.org/integration/autoland/rev/55c57fe1635c Part 3: Make JSRuntime::supportedImportAssertions not accessible from ParseTask. r=nbp
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: