1834826 - Folder mode header context menu should not be the one of the very first item in the folder pane instead

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, task)

Description

[Martin Giger [:freaktechnik]]

Currently, when right clicking on any folder mode header, focus moves to the very first item in the folder pane and shows the context menu of that item.

This fairly disorienting, especially since the actions don't actually map to where your mouse is. With the kebab menu on the folder mode headers coming to every mode for moving them around, we should consider if we want to just show the kebab menu as context menu on those headers instead. This would mean that right clicking will not change focus.

Comment 1

[Alessandro Castellani [:aleca]]

We should prevent the showing of the context menu if the event.target of the right click is on the folder mode header.

Comment 2

[Martin Giger [:freaktechnik]]

Attachment: Bug 1834826 - Don't show folder context menu on mode headers. r=#thunderbird-front-end-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dae2cc4bffb1
Don't show folder context menu on mode headers. r=aleca

Comment 4

[Martin Giger [:freaktechnik]]

Comment on attachment 9337816 [details]
Bug 1834826 - Don't show folder context menu on mode headers. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Context menu with unrelated actions shown when right clicking folder pane mode header
Testing completed (on c-c, etc.): Manually tested on c-c.
Risk to taking this patch (and alternatives if risky): Affects the not-displaying logic of the folder pane context menu. Should be fairly low risk.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9337816 [details]
Bug 1834826 - Don't show folder context menu on mode headers. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 115.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/8a2753d5d054