1834882 - Import modules statically that cause circular dependencies

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task)

Description

[Issam Mani [:issammani]]

Context

Formautofill code is shared with iOS that uses webpack to bundle JS. In desktop code we use ChromeUtils.defineESModuleGetters to load modules lazily. This doesn't exist in standard JS. We try to mimic this behaviour by using internal webpack APIs. This, however, doesn't have any mechanism to handle circular dependencies. Ideally we shouldn't have any circular dependencies, but since we do, we can just import these modules statically since static imports handle this natively.

Comment 1

[Issam Mani [:issammani]]

Attachment: Bug 1834882 - Import modules that cause circular dependencies statically. r=#credential-management-reviewers,dimi!

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1834882 - Refactor FieldScanner by extracting form autofill heuristic logic r=issammani

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ba369a8f67f
Refactor FieldScanner by extracting form autofill heuristic logic r=issammani

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0ba369a8f67f