1834883 - OpenPGP Message Security dialog positioned incorrectly when used multiple times

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Sören Hentzschel]

STR:

1. Open an e-mail with OpenPGP signature
2. Press the OpenPGP button in the message header
3. Repeat step 2 a few times

Actual:

• When opening the dialog the first time: correct position
• When opening the dialog the second time: correct position
• When opening the dialog the third time: totally wrong position
• When opening the dialog the fourth time: different than before, but still totally wrong position

Please see https://www.youtube.com/shorts/Org-YoCteRg

Expected:

The dialog should always open on the same position.

Tested on Thunderbird Daily 115.0a1 (2023-05-23) on macOS 13.3.1. The issue does not exist in Thunderbird 102.11.

Comment 1

[Sören Hentzschel]

Regression range according to mozregression:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=0ff6359339ff50327a6c1e7b3da75dc943366738&tochange=97c51978ca0669ece6c5f6586076e1f3265b78d7

Doesn't look like it's really caused by a comm-central change. To be sure I executed mozregression two times, both times with the same result. Maybe caused by a change in mozilla-central? Maybe bug 1809084? This was fixed in the time frame and caused some other positioning regressions as well.

Comment 2

[Sören Hentzschel]

It seems that this Thunderbird regression is caused by a change in mozilla-central but I can't bisect further with mozregression. Emilio, as author of the patch in bug 1809084 - Do you think bug 1809084 makes sense as regressor at all? See comment #1 why I suspected this change.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

I can see this on Linux too. The thing is that the panel grows each time it's shown. It might be caused by my change but it's not a bug in my code.

This code is very suspicious, why do you need that at all? The panel should auto-resize properly. Before the resize didn't move the panel but now it does to keep the anchor.

I suspect that code was just working around a XUL layout bug, but in any case you need to undo setting the previous height before measuring.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1834883 - Remove security panel layout workaround that's no longer needed. r=mkmelin

Also, use --panel-width so that the width accounts for shadows and other
decorations properly.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bb4289a18411
Remove security panel layout workaround that's no longer needed. r=mkmelin

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9340960 [details]
Bug 1834883 - Remove security panel layout workaround that's no longer needed. r=mkmelin

[Triage Comment]
approved for beta

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 115.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/05935f1aac3b