1834960 - Unused Locked<> in CssRule::Property can be removed

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Tess Hoffman [:zrhoffman]]

As mentioned in bug 1834674, CssRule::Propertyonly gets locked for reading, and not writing, but really theLocked<>` can just be removed.

Comment 1

[Tess Hoffman [:zrhoffman]]

Attachment: Bug 1834960 - Support non-Locked CSS rules at the FFI boundary r=#style,#layout

Depends on D178892

Comment 2

[Tess Hoffman [:zrhoffman]]

Attachment: Bug 1834960 - [css-properties-values-api] Remove Locked<> from CssRule::Property arc r=#style,#layout

Depends on D178892

Depends on D179038

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1834960 - Avoid some code duplication from the previous patches. r=zrhoffman,#style,#layout

This makes me a bit less uncomfortable about the previous changes :)

Note that some of this code gets modified in the following patch.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1834960 - Use non-locked rules for all rule types that can. r=zrhoffman,#style,#layout

Anything that doesn't need interior mutability doesn't need Locked<>
around it.

Depends on D179059

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ec2f71281b7
Support non-Locked CSS rules at the FFI boundary r=emilio
https://hg.mozilla.org/integration/autoland/rev/15ea211deec5
[css-properties-values-api] Remove Locked<> from CssRule::Property arc r=emilio

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5add0b5f1728
Avoid some code duplication from the previous patches. r=zrhoffman
https://hg.mozilla.org/integration/autoland/rev/6208f081bcc6
Use non-locked rules for all rule types that can. r=zrhoffman
https://hg.mozilla.org/integration/autoland/rev/b9e75060a406
apply code formatting via Lando

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9ec2f71281b7
https://hg.mozilla.org/mozilla-central/rev/15ea211deec5
https://hg.mozilla.org/mozilla-central/rev/5add0b5f1728
https://hg.mozilla.org/mozilla-central/rev/6208f081bcc6
https://hg.mozilla.org/mozilla-central/rev/b9e75060a406