1834971 - Add optional "data" field to WebDriver Error classes

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

For bug 1822466 and most likely bug 1830884 as well we need a better JSON serialization and deserialization of WebDriver error classes, especially for those classes that need extra information like a nodeId (eg. no such element, stale element reference). Reason is that this extra information needs to be still available and cannot simply be parsed our of random error messages.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1834971 - [remote] Add optional data field to WebDriver error classes.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ef568d7513d
[remote] Add optional data field to WebDriver error classes. r=webdriver-reviewers,Sasha

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing leakcheck failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/e2a897420b820148c50013f1ead2e0fc1a305052

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | leakcheck | default 4432 bytes leaked (Mutex, PollableEvent, ReentrantMonitor, nsAStreamCopier, nsPipe, ...)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5c24f93579f
[remote] Add optional data field to WebDriver error classes. r=webdriver-reviewers,Sasha

Comment 5

[Sandor Molnar[:smolnar]]

Got backed out by mistake.
Relanded

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b5c24f93579f