1835099 - Add a test that RFP is correctly applied in partitioned Service Workers

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement)

Description

[Tom Ritter [:tjr]]

This code is designed to handle the case where we have only a URI and OA, and need to determine if we should exempt from RFP or not. The URI might be a subdocument underneath a top-level document (the top-level document would be the partitionKey, either mFirstPartyDomain or mPartitionKey)

AFAIK the only place we actually need this is for Service Workers - but we definitely need it. We should take an existing Service Worker test that involved partitionKeys and add an RFP check into it.

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1835099: Check the Partition Key in both flows r?timhuang

Depends on D179106

Comment 2

[Tom Ritter [:tjr]]

Attachment: WIP: Bug 1835099: RFP Debug Logging

I find myself requently rewriting a subset of these
logging statements all the time, so maybe we should
just put them in the code

Depends on D179107

Comment 3

[Phabricator Automation]

Comment on attachment 9335927 [details]
WIP: Bug 1835099: RFP Debug Logging

Revision D179108 was moved to bug 1825561. Setting attachment 9335927 [details] to obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/811725f84ff2
Check the Partition Key in both flows r=timhuang

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/811725f84ff2

Comment 6

[Tom Ritter [:tjr]]

[Tracking Requested - why for this release]: I would like to uplift this to ESR 115 for Tor Browser, so they do not have to carry the patch.

Comment 7

[Tom Ritter [:tjr]]

Attachment: Bug 1835099: Check the Partition Key in both flows (ESR) r=timhuang

Depends on D183523

Comment 8

[Tom Ritter [:tjr]]

Comment on attachment 9343778 [details]
Bug 1835099: Check the Partition Key in both flows (ESR) r=timhuang

The ESR 115 Landing Order is Bug 1825561 -> Bug 1835099 -> Bug 1842678

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This patch is needed for correct application of RFP to service workers when a domain is exempted. Otherwise
• User impact if declined: It's necessary for Tor, so they will need to carry the patch if we don't uplift it.
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects users with RFP enabled

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9343778 [details]
Bug 1835099: Check the Partition Key in both flows (ESR) r=timhuang

Approved for 115.1esr.

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/01a2b291ead0