1835172 - Performance API should not clear user entries on memory pressure

Status: RESOLVED FIXED

(Core :: Performance: General, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

The performance API allows for unlimited entries to be added. We added this, but put in code to clear them on memory pressure. The problem with this is that pages calling performance.measure() will throw if the user mark has been cleared out from under them. Pages don't expect this, and a throw there can cause the page to break.

We saw this recently on android with the SP3 benchmark prototype, which would randomly stop if you hit Retest because measure() threw

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1835172: Don't clear performance user entries on MemoryPressure events r=smaug

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a815fe6c9241
Don't clear performance user entries on MemoryPressure events r=smaug

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/a815fe6c9241