1835177 - Modernize SVGAttrTearoffTable to use UniquePtr

Status: RESOLVED FIXED

(Core :: SVG, task)

Description

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

When looking at bug 1604498, I noticed that SVGAttrTearoffTable uses raw pointers and new / delete.

We should modernize to use UniquePtr/MakeUnique there.

Comment 1

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

Attachment: Bug 1835177: Modernize SVGAttrTearoffTable to use StaticAutoPtr to manage deletion. r?#layout-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e85ff01a1c5d
Modernize SVGAttrTearoffTable to use UniquePtr. r=boris

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e85ff01a1c5d

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out as requested.

• backout: https://hg.mozilla.org/mozilla-central/rev/b4990ee5aecd2abe7f8d1ee95a4761ece008c2ed

Comment 5

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

(In reply to Natalia Csoregi [:nataliaCs] from comment #4)

Backed out as requested.

Thanks! That addresses bug 1835996.

I've updated the patch to avoid that issue, and I'll re-land later on today (giving the metrics a chance to be updated, so we can confirm that they don't regress again).

Leaving needinfo open to remind me to re-land.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b37ec4bc7ce4
Modernize SVGAttrTearoffTable to use StaticAutoPtr to manage deletion. r=boris

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/b37ec4bc7ce4