Closed
Bug 1835232
Opened 3 years ago
Closed 3 years ago
Refactor simulateLinkClick to use sinon
Categories
(DevTools :: General, task)
DevTools
General
Tracking
(firefox115 fixed)
RESOLVED
FIXED
115 Branch
| Tracking | Status | |
|---|---|---|
| firefox115 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
Details
Attachments
(1 file)
The setup is a bit complex and could be simplified if we use sinon
Also, the second parameter is never used, so we can simplify even further
|
Assignee | |
Comment 1•3 years ago
|
||
We now use sinon to replace the override so we don't have
to handle restoring original methods ourselves.
We also remove anything that isn't useful (second unused
argument, clearTimeout, …).
Depends on D179193
|
||
Updated•3 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/043946544193
[devtools] Refactor simulateLinkClick. r=jdescottes,devtools-reviewers.
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox115:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•